From: Jeff King Date: Thu, 23 Apr 2020 21:04:09 GMT Subject: Re: [PATCH 1/2] test-bloom: fix some whitespace issues Message-ID: <20200423210409.GB1635761@coredump.intra.peff.net> In-Reply-To: <20200423210155.GA46862@syl.local> On Thu, Apr 23, 2020 at 03:01:55PM -0600, Taylor Blau wrote: > On Thu, Apr 23, 2020 at 04:59:07PM -0400, Jeff King wrote: > > Signed-off-by: Jeff King > > --- > > t/helper/test-bloom.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c > > index ce412664ba..f9c0ce2bae 100644 > > --- a/t/helper/test-bloom.c > > +++ b/t/helper/test-bloom.c > > @@ -27,7 +27,7 @@ static void print_bloom_filter(struct bloom_filter *filter) { > > } > > printf("Filter_Length:%d\n", (int)filter->len); > > printf("Filter_Data:"); > > - for (i = 0; i < filter->len; i++){ > > + for (i = 0; i < filter->len; i++) { > > Thanks for fixing the spacing, but I wonder if these braces should be > here at all. Since the body is one line long, maybe this should just be: > > for (i = 0; i < filter->len; i++) > printf("%02x|", filter->data[i]); I have to admit that I don't care either way, and I think we spend too much time quibbling about braces or not-braces. It was really the bad indentation that I cared about most. -Peff