Re: [PATCH 1/2] test-bloom: fix some whitespace issues
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Apr 23, 2020, 21:01 UTC
- Message-ID
- <20200423210155.GA46862@syl.local>
- In-Reply-To
- <20200423205907.GA1634224@coredump.intra.peff.net>
On Thu, Apr 23, 2020 at 04:59:07PM -0400, Jeff King wrote:
Show 15 quoted lines
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> t/helper/test-bloom.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/t/helper/test-bloom.c b/t/helper/test-bloom.c
> index ce412664ba..f9c0ce2bae 100644
> --- a/t/helper/test-bloom.c
> +++ b/t/helper/test-bloom.c
> @@ -27,7 +27,7 @@ static void print_bloom_filter(struct bloom_filter *filter) {
> }
> printf("Filter_Length:%d\n", (int)filter->len);
> printf("Filter_Data:");
> - for (i = 0; i < filter->len; i++){
> + for (i = 0; i < filter->len; i++) {Thanks for fixing the spacing, but I wonder if these braces should be here at all. Since the body is one line long, maybe this should just be:
for (i = 0; i < filter->len; i++)
printf("%02x|", filter->data[i]);Show 9 quoted lines
> printf("%02x|", filter->data[i]);
> }
> printf("\n");
> @@ -50,13 +50,13 @@ int cmd__bloom(int argc, const char **argv)
> printf("Murmur3 Hash with seed=0:0x%08x\n", hashed);
> }
>
> - if (!strcmp(argv[1], "generate_filter")) {
> + if (!strcmp(argv[1], "generate_filter")) {This spot looks good, and ditto for fixing the indentation.
Show 7 quoted lines
> struct bloom_filter filter;
> int i = 2;
> filter.len = (settings.bits_per_entry + BITS_PER_WORD - 1) / BITS_PER_WORD;
> filter.data = xcalloc(filter.len, sizeof(unsigned char));
>
> - if (!argv[2]){
> + if (!argv[2]) {Same note here about the brace.
Show 22 quoted lines
> die("at least one input string expected");
> }
>
> @@ -68,7 +68,7 @@ int cmd__bloom(int argc, const char **argv)
> print_bloom_filter(&filter);
> }
>
> - if (!strcmp(argv[1], "get_filter_for_commit")) {
> + if (!strcmp(argv[1], "get_filter_for_commit")) {
> struct object_id oid;
> const char *end;
> if (parse_oid_hex(argv[2], &oid, &end))
> @@ -78,4 +78,4 @@ int cmd__bloom(int argc, const char **argv)
> }
>
> return 0;
> -}
> \ No newline at end of file
> +}
> --
> 2.26.2.827.g3c1233342b
>Thanks, Taylor