git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] credential: fix matching URLs with multiple levels in path

From
Jeff King <peff@peff.net>
Date
Apr 22, 2020, 20:04 UTC
Message-ID
<20200422200424.GF558336@coredump.intra.peff.net>
In-Reply-To
<20200422195109.2224035-1-sandals@crustytoothpaste.net>
On Wed, Apr 22, 2020 at 07:51:09PM +0000, brian m. carlson wrote:
Show 6 quoted lines
> Changes from v1:
> * Continue to encode slashes in usernames.
> * Add a test for encoding slashes in usernames.
> * Hoist existing tests near the other percent-encoding tests.
> * Update commit message.
> * Remove debugging information.

Thank for an easy-to-read explanation and patch (as usual). This version looks good to me.

I think there's still an open question on:
  [credential "no-scheme.example.com"]

config sections. I feel like that's something we never really intended to support and should discourage, but it seems as though it may be in wide use. But it's definitely a separate patch, and it sounds like Dscho is working on it.

-Peff
Previous: brian m. carlsonNext: Carlo Marcelo Arenas Belón
Message 13 of 20 in “Credential helpers are no longer invoked in case of having sub-folder parts in a repository URL. Since 2.26.1 version”
  1. Ilya TretyakovApr 21, 2020
  2. Jeff KingApr 21, 2020
  3. brian m. carlsonApr 22, 2020
  4. Jonathan NiederApr 22, 2020
  5. Jeff KingApr 22, 2020
  6. brian m. carlsonApr 22, 2020
  7. Jeff KingApr 22, 2020
  8. Johannes SchindelinApr 22, 2020
  9. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 22, 2020
  10. Jeff KingApr 22, 2020
  11. brian m. carlsonApr 22, 2020
  12. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 22, 2020
  13. Jeff KingApr 22, 2020
  14. Carlo Marcelo Arenas BelónApr 24, 2020
  15. Junio C HamanoApr 24, 2020
  16. redential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 25, 2020
  17. Eric SunshineApr 26, 2020
  18. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 26, 2020
  19. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 27, 2020
  20. Junio C HamanoApr 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.