From: Jeff King <peff@peff.net>
Date: Wed, 22 Apr 2020 20:04:24 GMT
Subject: Re: [PATCH v2] credential: fix matching URLs with multiple levels in path
Message-ID: <20200422200424.GF558336@coredump.intra.peff.net>
In-Reply-To: <20200422195109.2224035-1-sandals@crustytoothpaste.net>

On Wed, Apr 22, 2020 at 07:51:09PM +0000, brian m. carlson wrote:

> Changes from v1:
> * Continue to encode slashes in usernames.
> * Add a test for encoding slashes in usernames.
> * Hoist existing tests near the other percent-encoding tests.
> * Update commit message.
> * Remove debugging information.

Thank for an easy-to-read explanation and patch (as usual). This version
looks good to me.

I think there's still an open question on:

  [credential "no-scheme.example.com"]

config sections. I feel like that's something we never really intended
to support and should discourage, but it seems as though it may be in
wide use. But it's definitely a separate patch, and it sounds like Dscho
is working on it.

-Peff