git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Credential helpers are no longer invoked in case of having sub-folder parts in a repository URL. Since 2.26.1 version

From
Jeff King <peff@peff.net>
Date
Apr 22, 2020, 01:36 UTC
Message-ID
<20200422013629.GA3559880@coredump.intra.peff.net>
In-Reply-To
<20200422012817.GD103469@google.com>
On Tue, Apr 21, 2020 at 06:28:17PM -0700, Jonathan Nieder wrote:
Show 11 quoted lines
> Thanks.  Here's another (though I haven't tried bisecting yet):
> 
> 	echo url='https://github.com/git/git' |
> 	GIT_TERMINAL_PROMPT=0 \
> 	git -c credential.helper= \
> 		-c credential.github.com.helper='!echo username=foo; echo password=bar;:' \
> 		credential fill
> 
> produces
> 
> 	fatal: could not read Username for 'https://github.com': terminal prompts disabled

It's almost certainly the same commit. The credential_match() function would have said "aha, there is no protocol in the pattern, so match any protocol". But now we are trying to match full URLs.

TBH, I'm not sure if the original was actually sane (especially in light of all of the recent confusion around missing protocols).

-Peff
Previous: Jonathan NiederNext: brian m. carlson
Message 5 of 20 in “Credential helpers are no longer invoked in case of having sub-folder parts in a repository URL. Since 2.26.1 version”
  1. Ilya TretyakovApr 21, 2020
  2. Jeff KingApr 21, 2020
  3. brian m. carlsonApr 22, 2020
  4. Jonathan NiederApr 22, 2020
  5. Jeff KingApr 22, 2020
  6. brian m. carlsonApr 22, 2020
  7. Jeff KingApr 22, 2020
  8. Johannes SchindelinApr 22, 2020
  9. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 22, 2020
  10. Jeff KingApr 22, 2020
  11. brian m. carlsonApr 22, 2020
  12. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 22, 2020
  13. Jeff KingApr 22, 2020
  14. Carlo Marcelo Arenas BelónApr 24, 2020
  15. Junio C HamanoApr 24, 2020
  16. redential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 25, 2020
  17. Eric SunshineApr 26, 2020
  18. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 26, 2020
  19. credential: fix matching URLs with multiple levels in pathbrian m. carlson, Apr 27, 2020
  20. Junio C HamanoApr 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.