From: Jeff King <peff@peff.net>
Date: Wed, 22 Apr 2020 01:36:29 GMT
Subject: Re: Credential helpers are no longer invoked in case of having sub-folder parts in a repository URL. Since 2.26.1 version
Message-ID: <20200422013629.GA3559880@coredump.intra.peff.net>
In-Reply-To: <20200422012817.GD103469@google.com>

On Tue, Apr 21, 2020 at 06:28:17PM -0700, Jonathan Nieder wrote:

> Thanks.  Here's another (though I haven't tried bisecting yet):
> 
> 	echo url='https://github.com/git/git' |
> 	GIT_TERMINAL_PROMPT=0 \
> 	git -c credential.helper= \
> 		-c credential.github.com.helper='!echo username=foo; echo password=bar;:' \
> 		credential fill
> 
> produces
> 
> 	fatal: could not read Username for 'https://github.com': terminal prompts disabled

It's almost certainly the same commit. The credential_match() function
would have said "aha, there is no protocol in the pattern, so match any
protocol". But now we are trying to match full URLs.

TBH, I'm not sure if the original was actually sane (especially in light
of all of the recent confusion around missing protocols).

-Peff