Re: [PATCH 0/6] Doc: drop support for docbook-xsl before 1.74
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Mar 30, 2020, 10:46 UTC
- Message-ID
- <20200330104605.GA6595@camp.crustytoothpaste.net>
- In-Reply-To
- <cover.1585486103.git.martin.agren@gmail.com>
On 2020-03-29 at 13:18:04, Martin Ågren wrote:
Show 17 quoted lines
> In the documentation Makefile and a few helper conf and xsl files, we > carry various workarounds to make the docs build at all or to look > better with older docbook-xsl versions. Let's see if we can't just drop > that support. All of this seems to have been useful at one point, but I > doubt that anyone needs this nowadays. This was also suggested in [1]. > > The final commit in this series bumps the minimum required version of > docbook-xsl to 1.74.0, which is from June 2008. The whole series should > be a no-op unless you're on an older release than that. That said, I've > only tested this with the version that comes with my OS, 1.79.1. > > After this series, user-manual.conf still refers to older docbook-xsl > versions. The proper fix there might be to actually be a bit more > aggressive and drop that hunk, making the rendered docs prettier. > There's some history there, including mentions of texinfo, which is > outside my comfort zone. I've got work in progress there, but I'd rather > submit that separately from these "expected no-op" patches.
This seems sane to me and I'm all for dropping support for a twelve-year-old version of the DocBook XSL stylesheets. On the odd chance that someone did need to download a newer version, this is a dependency that's easy to set up and build.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204