git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 10/20] t5319: make test work with SHA-256

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Dec 27, 2019, 21:35 UTC
Message-ID
<20191227213528.GB6570@camp.crustytoothpaste.net>
In-Reply-To
<54d80d36-f9b9-1c92-faf0-41bbcbe0a133@gmail.com>
On 2019-12-26 at 14:50:09, Derrick Stolee wrote:
Show 10 quoted lines
> On 12/21/2019 2:49 PM, brian m. carlson wrote:
> > @@ -387,7 +401,7 @@ test_expect_success 'force some 64-bit offsets with pack-objects' '
> >  	pack64=$(git pack-objects --index-version=2,0x40 objects64/pack/test-64 <obj-list) &&
> >  	idx64=objects64/pack/test-64-$pack64.idx &&
> >  	chmod u+w $idx64 &&
> > -	corrupt_data $idx64 2999 "\02" &&
> > +	corrupt_data $idx64 $(test_oid idxoff) "\02" &&
> 
> Sorry that this was not a better-calculated value, but
> your approach works well here.

That's okay. I appreciate that you attempted to make things robust, and the documentary value of the variables was helpful in fixing these tests.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Derrick StoleeNext: brian m. carlson
Message 17 of 28 in “SHA-256 test fixes, part 7”
  1. 00/20 SHA-256 test fixes, part 7brian m. carlson, Dec 21, 2019
  2. 01/20 t4054: make hash-size independentbrian m. carlson, Dec 21, 2019
  3. 03/20 t4134: compute appropriate length constantbrian m. carlson, Dec 21, 2019
  4. 02/20 t4066: compute index line in diffsbrian m. carlson, Dec 21, 2019
  5. 04/20 t4200: make hash size independentbrian m. carlson, Dec 21, 2019
  6. 06/20 t4204: make hash size independentbrian m. carlson, Dec 21, 2019
  7. 08/20 t5318: update for SHA-256brian m. carlson, Dec 21, 2019
  8. 09/20 t5319: change invalid offset for SHA-256 compatibilitybrian m. carlson, Dec 21, 2019
  9. Derrick StoleeDec 26, 2019
  10. 07/20 t4300: abstract away SHA-1-specific constantsbrian m. carlson, Dec 21, 2019
  11. 11/20 t5324: make hash size independentbrian m. carlson, Dec 21, 2019
  12. 10/20 t5319: make test work with SHA-256brian m. carlson, Dec 21, 2019
  13. Eric SunshineDec 22, 2019
  14. brian m. carlsonDec 22, 2019
  15. Michael ClarkDec 23, 2019
  16. Derrick StoleeDec 26, 2019
  17. brian m. carlsonDec 27, 2019
  18. 13/20 t5510: make hash size independentbrian m. carlson, Dec 21, 2019
  19. 14/20 t5512: abstract away SHA-1-specific constantsbrian m. carlson, Dec 21, 2019
  20. 17/20 t5540: make hash size independentbrian m. carlson, Dec 21, 2019
  21. 12/20 t5504: make hash algorithm independentbrian m. carlson, Dec 21, 2019
  22. 15/20 t5530: compute results based on object lengthbrian m. carlson, Dec 21, 2019
  23. 19/20 t5601: switch into repository to hash objectbrian m. carlson, Dec 21, 2019
  24. 18/20 t5562: use $ZERO_OIDbrian m. carlson, Dec 21, 2019
  25. 20/20 t5604: make hash independentbrian m. carlson, Dec 21, 2019
  26. 16/20 t5537: make hash size independentbrian m. carlson, Dec 21, 2019
  27. 05/20 t4202: abstract away SHA-1-specific constantsbrian m. carlson, Dec 21, 2019
  28. Derrick StoleeDec 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.