From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Fri, 27 Dec 2019 21:35:28 GMT
Subject: Re: [PATCH 10/20] t5319: make test work with SHA-256
Message-ID: <20191227213528.GB6570@camp.crustytoothpaste.net>
In-Reply-To: <54d80d36-f9b9-1c92-faf0-41bbcbe0a133@gmail.com>

On 2019-12-26 at 14:50:09, Derrick Stolee wrote:
> On 12/21/2019 2:49 PM, brian m. carlson wrote:
> > @@ -387,7 +401,7 @@ test_expect_success 'force some 64-bit offsets with pack-objects' '
> >  	pack64=$(git pack-objects --index-version=2,0x40 objects64/pack/test-64 <obj-list) &&
> >  	idx64=objects64/pack/test-64-$pack64.idx &&
> >  	chmod u+w $idx64 &&
> > -	corrupt_data $idx64 2999 "\02" &&
> > +	corrupt_data $idx64 $(test_oid idxoff) "\02" &&
> 
> Sorry that this was not a better-calculated value, but
> your approach works well here.

That's okay.  I appreciate that you attempted to make things robust, and
the documentary value of the variables was helpful in fixing these
tests.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204