git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 16/20] t5537: make hash size independent

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Dec 21, 2019, 19:49 UTC
Message-ID
<20191221194936.1346664-17-sandals@crustytoothpaste.net>
In-Reply-To
<20191221194936.1346664-1-sandals@crustytoothpaste.net>

This test modifies a pkt-line stream with sed to change a line with "shallow" to "unshallow". However, this modification is dependent on the size of the hash in use; with SHA-256, the pkt-line length is different, leading to the sed command having no effect.

Use test_oid_cache to specify the correct values for each hash so that the test continues to work.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 t/t5537-fetch-shallow.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/t5537-fetch-shallow.sh b/t/t5537-fetch-shallow.sh
index 97a67728ca..9e16512fe3 100755
--- a/t/t5537-fetch-shallow.sh
+++ b/t/t5537-fetch-shallow.sh
@@ -15,7 +15,11 @@ test_expect_success 'setup' '
 	commit 2 &&
 	commit 3 &&
 	commit 4 &&
-	git config --global transfer.fsckObjects true
+	git config --global transfer.fsckObjects true &&
+	test_oid_cache <<-EOF
+	sed sha1:s/0034shallow %s/0036unshallow %s/
+	sed sha256:s/004cshallow %s/004eunshallow %s/
+	EOF
 '
 
 test_expect_success 'setup shallow clone' '
@@ -239,7 +243,7 @@ test_expect_success 'shallow fetches check connectivity before writing shallow f
 	# with an empty packfile. This is done by refetching with a shorter
 	# depth (to ensure that the packfile is empty), and overwriting the
 	# shallow line in the response with the unshallow line we want.
-	printf "s/0034shallow %s/0036unshallow %s/" \
+	printf "$(test_oid sed)" \
 	       "$(git -C "$REPO" rev-parse HEAD)" \
 	       "$(git -C "$REPO" rev-parse HEAD^)" \
 	       >"$HTTPD_ROOT_PATH/one-time-sed" &&
Previous: brian m. carlsonNext: brian m. carlson
Message 26 of 28 in “SHA-256 test fixes, part 7”
  1. 00/20 SHA-256 test fixes, part 7brian m. carlson, Dec 21, 2019
  2. 01/20 t4054: make hash-size independentbrian m. carlson, Dec 21, 2019
  3. 03/20 t4134: compute appropriate length constantbrian m. carlson, Dec 21, 2019
  4. 02/20 t4066: compute index line in diffsbrian m. carlson, Dec 21, 2019
  5. 04/20 t4200: make hash size independentbrian m. carlson, Dec 21, 2019
  6. 06/20 t4204: make hash size independentbrian m. carlson, Dec 21, 2019
  7. 08/20 t5318: update for SHA-256brian m. carlson, Dec 21, 2019
  8. 09/20 t5319: change invalid offset for SHA-256 compatibilitybrian m. carlson, Dec 21, 2019
  9. Derrick StoleeDec 26, 2019
  10. 07/20 t4300: abstract away SHA-1-specific constantsbrian m. carlson, Dec 21, 2019
  11. 11/20 t5324: make hash size independentbrian m. carlson, Dec 21, 2019
  12. 10/20 t5319: make test work with SHA-256brian m. carlson, Dec 21, 2019
  13. Eric SunshineDec 22, 2019
  14. brian m. carlsonDec 22, 2019
  15. Michael ClarkDec 23, 2019
  16. Derrick StoleeDec 26, 2019
  17. brian m. carlsonDec 27, 2019
  18. 13/20 t5510: make hash size independentbrian m. carlson, Dec 21, 2019
  19. 14/20 t5512: abstract away SHA-1-specific constantsbrian m. carlson, Dec 21, 2019
  20. 17/20 t5540: make hash size independentbrian m. carlson, Dec 21, 2019
  21. 12/20 t5504: make hash algorithm independentbrian m. carlson, Dec 21, 2019
  22. 15/20 t5530: compute results based on object lengthbrian m. carlson, Dec 21, 2019
  23. 19/20 t5601: switch into repository to hash objectbrian m. carlson, Dec 21, 2019
  24. 18/20 t5562: use $ZERO_OIDbrian m. carlson, Dec 21, 2019
  25. 20/20 t5604: make hash independentbrian m. carlson, Dec 21, 2019
  26. 16/20 t5537: make hash size independentbrian m. carlson, Dec 21, 2019
  27. 05/20 t4202: abstract away SHA-1-specific constantsbrian m. carlson, Dec 21, 2019
  28. Derrick StoleeDec 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.