Re: [RFC PATCH v3 3/3] trace2: write overload message to sentinel files

From: Josh Steadmon <steadmon@google.com>
Date: Sep 16, 2019, 18:20 UTC
Message-ID: <20190916182030.GB11295@google.com>
In-Reply-To: <4aa3022d-743b-2ff6-8a8b-9cd9dc8692a2@jeffhostetler.com>

On 2019.09.16 10:11, Jeff Hostetler wrote:

Show 40 quoted lines

> 
> 
> On 9/16/2019 8:07 AM, Derrick Stolee wrote:
> > On 9/13/2019 8:26 PM, Josh Steadmon wrote:
> > > Add a new "overload" event type for trace2 event destinations. Write
> > > this event into the sentinel file created by the trace2.maxFiles
> > > feature. Bump up the event format version since we've added a new event
> > > type.
> > > 
> > > Writing this message into the sentinel file is useful for tracking how
> > > often the overload protection feature is triggered in practice.
> > 
> > Putting meaningful data into the sentinel file is valuable. It's
> > important to know a bit about when and why this happened. A user
> > would be able to inspect the modified time, and the directory info
> > you include is unnecessary. The data you include is only for the
> > log aggregator to keep valuable data around overloads.
> > > +`"overload"`::
> > > +	This event is created in a sentinel file if we are overloading a target
> > > +	trace directory (see the trace2.maxFiles config option).
> > > ++
> > > +------------
> > > +{
> > > +	"event":"overload",
> > > +	...
> > > +	"dir":"/trace/target/dir/", # The configured trace2 target directory
> > > +	"evt":"2",		    # EVENT format version
> > > +}
> > That said, do we really need to resort to a new event format and
> > event type? Could we instead use the "data" event with a key
> > "overload" and put the target dir in the value?
> > 
> > Thanks,
> > -Stolee
> > 
> 
> If I understand the code here, the overload event/message is
> only written to the sentinel file -- it is not written to a
> regular trace2 log file, so regular log file consumers will
> never see this event, right?

Well, I guess it's hard to define what is a "regular log file consumer". In our case, our collection system will treat sentinel files like any other trace file, so it's useful to have it match the expected trace format.

At least for our use, we don't want the sentinel files treated specially, because we want the log collection system to just do its thing and remove the file after processing, which lets Git know that it's ok to start writing traces again.

> That message could be in any format, right?  And you could write
> as much or as little data into the sentinel file as you want.

To me it seems that it would be less surprising on the users' side if any data written to the sentinel file matches the format of the requested traces. If I have an automated process that's reading JSON from a directory full of files, I don't want to have to add a special case where one file might have perf-format data (or vice versa).

Show 8 quoted lines

> There's no compelling reason to extend the existing trace2 format
> to have a new message type, so I'm not seeing a reason to add the
> event-type nor to increment the version number.
> 
> The existing trace2 formats and messages/event-types are defined
> and driven by the Trace2 API calls presented to upper layers
> (consumers of the public trace2_*() functions and macros defined
> in trace2.h).  This overload event doesn't fit that model.

Yeah, I did feel like this might be overkill. Do you think Stolee's suggestion to use a "data" event instead would be acceptable?

> I think it'd be better to just directly write() a message -- in
> plain-text or JSON or whatever -- in tr2_create_sentinel() and
> not try to piggy-back on the existing format machinery in the
> tr2_tgt_*.c files.

I had a version that did this originally, but I don't really like having an unexpected special case where we just write a static JSON string. It feels like an ugly corner case, and would be surprising to users, IMO. But if everyone thinks this is a better approach, I suppose I could just add a switch statement in tr2_create_sentinel() that looks at the sysenv_var field of the tr2_dst.