git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] You can't have single quote in your username

From
Jeff King <peff@peff.net>
Date
Aug 28, 2019, 14:56 UTC
Message-ID
<20190828145640.GC14432@sigill.intra.peff.net>
In-Reply-To
<20190828143315.GA4477@instance-template-2.europe-west6-a.c.vaulted-journal-250706.internal>
On Wed, Aug 28, 2019 at 02:33:15PM +0000, Giuseppe Crino' wrote:
Show 7 quoted lines
> On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote:
> > But we'd still need something at least for
> > GECOS, where "Your Name,,,," is common.
> 
> As I understand this, those commas are *not* removed by
> strbuf_addstr_without_crud(). Instead they're skipped from /etc/pass
> -- see `ident.c/copy_gecos()`.

Yeah, you're right. This is a good example of how we are completely unclear on how often the crud-removal is helping. :)

But I think that does put us one step closer to possibly dropping the crud-removal, if gecos is already handled (and hopefully "mailinfo" is already cleaning up the names it parsers).

-Peff
Previous: Giuseppe Crino'Next: Giuseppe Crinò
Message 19 of 26 in “[BUG] You can't have single quote in your username”
  1. Giuseppe CrinòAug 22, 2019
  2. Pratyush YadavAug 22, 2019
  3. Junio C HamanoAug 22, 2019
  4. Giuseppe CrinòAug 23, 2019
  5. Michal SuchánekAug 23, 2019
  6. René ScharfeAug 22, 2019
  7. Bryan TurnerAug 22, 2019
  8. Emily ShafferAug 22, 2019
  9. Pratyush YadavAug 22, 2019
  10. SZEDER GáborAug 23, 2019
  11. Giuseppe CrinòAug 23, 2019
  12. SZEDER GáborAug 23, 2019
  13. Giuseppe CrinòAug 24, 2019
  14. Giuseppe CrinòAug 25, 2019
  15. Jeff KingAug 26, 2019
  16. Giuseppe Crino'Aug 27, 2019
  17. Michal SuchánekAug 27, 2019
  18. Giuseppe Crino'Aug 28, 2019
  19. Jeff KingAug 28, 2019
  20. Giuseppe CrinòAug 31, 2019
  21. Jeff KingSep 2, 2019
  22. Junio C HamanoSep 2, 2019
  23. Michal SuchánekSep 2, 2019
  24. Giuseppe CrinòSep 3, 2019
  25. Michal SuchánekSep 3, 2019
  26. SZEDER GáborAug 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.