Re: [BUG] You can't have single quote in your username

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 22, 2019, 16:24 UTC
Message-ID: <xmqqy2zlp3qn.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190822150614.o25g37pwfcaos2zn@localhost.localdomain>

Pratyush Yadav <me@yadavpratyush.com> writes:

> This strbuf_addstr_without_crud() function removes various characters 
> from the start and end of the author info, one of which is the single 
> quotation. I'm not sure why this is done, the more experienced folk 
> where will have the answer.

The logic there exists in order to remove cruft around the name on a typical e-mail header (remember, most of the very core-ish part of the Git was written and got solidified back when the Linux kernel was the primary client of the system, and many commits were created via "am"), e.g. sender's mail client may send something like this:

    From: 'Foo bar Baz' <my@name.xz>

and we do not want to take surrounding sq pair as part of the name.