From: Jeff King <peff@peff.net>
Date: Wed, 28 Aug 2019 14:56:41 GMT
Subject: Re: [BUG] You can't have single quote in your username
Message-ID: <20190828145640.GC14432@sigill.intra.peff.net>
In-Reply-To: <20190828143315.GA4477@instance-template-2.europe-west6-a.c.vaulted-journal-250706.internal>

On Wed, Aug 28, 2019 at 02:33:15PM +0000, Giuseppe Crino' wrote:

> On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote:
> > But we'd still need something at least for
> > GECOS, where "Your Name,,,," is common.
> 
> As I understand this, those commas are *not* removed by
> strbuf_addstr_without_crud(). Instead they're skipped from /etc/pass
> -- see `ident.c/copy_gecos()`.

Yeah, you're right. This is a good example of how we are completely
unclear on how often the crud-removal is helping. :)

But I think that does put us one step closer to possibly dropping the
crud-removal, if gecos is already handled (and hopefully "mailinfo" is
already cleaning up the names it parsers).

-Peff