Re: [RFC PATCH] userdiff: ship built-in driver config file

From: Jeff King <peff@peff.net>
Date: Jun 19, 2019, 18:42 UTC
Message-ID: <20190619184214.GB28145@sigill.intra.peff.net>
In-Reply-To: <CALM0=-=4b4j1brRN=Jnq4N+f+_vJXrL-JBAOxaLw0FgugNqX5w@mail.gmail.com>

On Wed, Jun 19, 2019 at 11:32:19PM +0800, LI, BO XUAN wrote:

Show 12 quoted lines

> >   [diff "foo"]
> >   xfuncname = "the pattern starts here...
> >   and continues through newlines!"
> >
> 
> If I recall correctly, the above version wouldn't work, but the
> following version would:
> 
> [diff "foo"]
>     xfuncname = "The pattern starts here..."
> "and continues here! But the indentation looks ugly,"
> "and we lose the ability to add comments inline (within pattern)"

I don't think that works for our config files either (it does in C, of course).

Show 12 quoted lines

> Actually, at the very beginning, I was imaging some syntax like this:
> 
> [diff "foo"]
>     xfuncname = "The pattern starts here..."
>     ; using '+=' will continue the pattern above
>     xfuncname += "and continues here!"
>     ; a '=' symbol will start a new pattern
>     xfuncname = "This is another pattern.."
>     xfuncname += "and remember, last one always wins"
> 
> The existing config parser does not support "+=" though, which is a
> nice feature to have in my opinion. Maybe there is a reason?

There's no particular reason that feature isn't there, but in general we've been very hesitant to add syntactic changes to the config files, since there are many parsers in the wild. In general, today's files are compatible with ones from 2005.

-Peff