Re: [RFC PATCH] userdiff: ship built-in driver config file

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 20, 2019, 07:41 UTC
Message-ID: <1db4a03e-5bc2-673d-6d89-bf654b785129@kdbg.org>
In-Reply-To: <20190619183931.GA28145@sigill.intra.peff.net>

Am 19.06.19 um 20:39 schrieb Jeff King:

> But without that, I have to wonder what problem we are really solving.

You have a point here.

> Now it's baked into the binary. Later it will be baked into the
> distribution, but we still don't want anybody to touch it because their
> changes will be overwritten.

Having the patterns outside the binary reduces our mental barrier to accept additional patterns or slightly modified patterns for new file types, like we had recently for octave that are just a small extension to the matlab patterns.

But we are not solving a technical problem or a problem our users have, AFAICS.

> I guess it's a little easier for somebody
> to find .../share/git-core/userdiff and use it as a template than it is
> to find the definitions in the source. But it's not exactly easy.

Having a slightly easiser to discover database may count as an advantage. ;)

-- Hannes