Re: [RFC PATCH] userdiff: ship built-in driver config file

From: Johannes Sixt <j6t@kdbg.org>
Date: Jun 19, 2019, 06:30 UTC
Message-ID: <1da78555-96eb-1206-679b-527911f6af29@kdbg.org>
In-Reply-To: <20190619034929.GA515@sigill.intra.peff.net>

Am 19.06.19 um 05:49 schrieb Jeff King:

Show 16 quoted lines

> On Tue, Jun 18, 2019 at 10:32:47PM +0200, Johannes Sixt wrote:
> 
>> Am 17.06.19 um 18:54 schrieb Boxuan Li:
>>> diff --git a/templates/this--userdiff b/templates/this--userdiff
>>> new file mode 100644
>>> index 0000000000..85114a7229
>>> --- /dev/null
>>> +++ b/templates/this--userdiff
>>
>> Why place this file in .git? To have per-repository diff drivers, we can
>> already specify them via 'git config'. This file should be installed in
>> the system.
> 
> I think it _could_ actually just be part of the system /etc/gitconfig,
> though it is kind of big, and Git has a tendency to parse the config
> more than necessary. I wonder if would add a noticeable slowdown.

But /etc/gitconfig would be the wrong place, because it would not be updated when a new version ships with new patterns.

I would suggest to install the file as $prefix/share/git-core/userdiff although the name "userdiff" sounds like an accident. How about .../filetypes?

-- Hannes