Re: [PATCH v2 1/1] ref-filter: sort detached HEAD lines firstly

From: Matthew DeVore <matvore@comcast.net>
Date: Jun 13, 2019, 01:56 UTC
Message-ID: <20190613015616.GG58112@comcast.net>
In-Reply-To: <xmqqo932ik7y.fsf@gitster-ct.c.googlers.com>

On Wed, Jun 12, 2019 at 02:09:53PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> Stepping back a bit, why are we even allowing the surrounding ()
> pair to be futzed by the translators?
> 
> IOW, shouldn't our code more like this from the beginning, with or
> without Chinese translation?
> 
> With a bit more work, we may even be able to lose "make sure this
> matches the one in wt-status.c" comment as losing the leading '('
> would take us one step closer to have an identical string here as we
> have in wt-status.c

I think my previous e-mail didn't make it to the public list, maybe since it contained non-ASCII text. The gist of that mail was that we have full-width parens in various zh_CN strings so it seems hacky to make just this one be half-width for the sake of code simplicity.

Giving this a bit more thought now, perhaps the fact that we want to be in-sync with the string in wt-status.c, combined with the fact that we already have "*" as half-width metacharacter in the "git branch" output, is a good enough excuse to drop "()" out of the translatable string, as your patch does.