Re: [RFC PATCH] ref-filter: sort detached HEAD lines firstly
- From
Matthew DeVore <matvore@comcast.net>
- Date
- Jun 11, 2019, 16:48 UTC
- Message-ID
- <20190611164834.GA58112@comcast.net>
- In-Reply-To
- <20190611004106.GB64137@google.com>
On Mon, Jun 10, 2019 at 05:41:06PM -0700, Jonathan Nieder wrote:
Show 9 quoted lines
> Git seems to be inconsistent about this. Documentation/CodingGuidelines > says > > - When there are multiple arms to a conditional and some of them > require braces, enclose even a single line block in braces for > consistency. E.g.: > > so you have some cover from there (and it matches what I'm used to, > too). :)
Thanks for finding that.
Show 14 quoted lines
> > [...] > >>> + LC_ALL=$zh_CN_locale LC_MESSAGES=$zh_CN_locale \ > >>> + git -C r1 branch >actual && > >>> + git -C r1 checkout - && > >> > >> Why call `checkout` after `branch`? That's unnecessary, we do not verify > >> anything after that call. > > > > It's to get the repo into a neutral state in case an additional testcase is > > added in the future. > > For this kind of thing, we tend to use test_when_finished so that the > test ends up in a clean state even if it fails.
Done. That will be used in the next roll-up.
Show 7 quoted lines
> > head -n 1 actual >first && > > # The first line should be enclosed by full-width parenthesis. > > grep '$'\xef\xbc\x88.*\xef\xbc\x89'' first && > > nit: older shells do not know how to do $'\x01' interpolation. > Probably best to use the raw UTF-8 directly here (it will be more > readable anyway).
Good point. I suppose we don't have to worry about dev's editors screwing up encoding since modern editors make this kind of thing easy to configure (and I suspect that all sane editors use UTF-8 as the default or at least won't mangle it...)