git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib: try harder to ensure a working jgit

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
May 14, 2019, 02:14 UTC
Message-ID
<20190514021419.GI7458@genre.crustytoothpaste.net>
In-Reply-To
<20190514020520.GI3654@pobox.com>
On Mon, May 13, 2019 at 10:05:20PM -0400, Todd Zullinger wrote:
Show 11 quoted lines
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 908ddb9c46..599fd70e14 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1522,7 +1522,7 @@ test_lazy_prereq NOT_ROOT '
>  '
>  
>  test_lazy_prereq JGIT '
> -	type jgit
> +	jgit --version
>  '

I think this is an improvement, not only because of the reasons you mentioned, but because we remove the use of "type", which is not guaranteed to be present in a POSIX shell.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Todd ZullingerNext: Jeff King
Message 2 of 11 in “test-lib: try harder to ensure a working jgit”
  1. test-lib: try harder to ensure a working jgitTodd Zullinger, May 14, 2019
  2. brian m. carlsonMay 14, 2019
  3. Jeff KingMay 14, 2019
  4. Junio C HamanoMay 15, 2019
  5. Todd ZullingerMay 15, 2019
  6. brian m. carlsonMay 15, 2019
  7. Jonathan NiederMay 14, 2019
  8. Ævar Arnfjörð BjarmasonMay 14, 2019
  9. Todd ZullingerMay 15, 2019
  10. Junio C HamanoMay 15, 2019
  11. test-lib: try harder to ensure a working jgitTodd Zullinger, May 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.