Re: [PATCH] test-lib: try harder to ensure a working jgit
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- May 14, 2019, 02:32 UTC
- Message-ID
- <20190514023245.GB34155@google.com>
- In-Reply-To
- <20190514020520.GI3654@pobox.com>
Todd Zullinger wrote:
Show 15 quoted lines
> The JGIT prereq uses 'type jgit' to determine whether jgit is present. > While this should be sufficient, if the jgit found is broken we'll waste > time running tests which fail due to no fault of our own. > > Use 'jgit --version' instead, to catch some badly broken jgit > installations. > > Signed-off-by: Todd Zullinger <tmz@pobox.com> > --- > I ran into such a broken jgit on Fedora >= 30¹. This is clearly a > problem in the Fedora jgit package which will hopefully be resolved > soon. But it may be good to avoid wasting time debugging tests which > fail due to a broken tool outside of our control. > > ¹ https://bugzilla.redhat.com/1709624
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
It would be nice to describe that bug in the commit message, to save readers some head scratching.
Thanks, Jonathan