From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 14 May 2019 02:14:19 GMT
Subject: Re: [PATCH] test-lib: try harder to ensure a working jgit
Message-ID: <20190514021419.GI7458@genre.crustytoothpaste.net>
In-Reply-To: <20190514020520.GI3654@pobox.com>

On Mon, May 13, 2019 at 10:05:20PM -0400, Todd Zullinger wrote:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 908ddb9c46..599fd70e14 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1522,7 +1522,7 @@ test_lazy_prereq NOT_ROOT '
>  '
>  
>  test_lazy_prereq JGIT '
> -	type jgit
> +	jgit --version
>  '

I think this is an improvement, not only because of the reasons you
mentioned, but because we remove the use of "type", which is not
guaranteed to be present in a POSIX shell.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204