[PATCH v4 02/34] builtin rebase: use oideq()
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- Apr 16, 2019, 09:33 UTC
- Message-ID
- <20190416093341.17079-3-pclouds@gmail.com>
- In-Reply-To
- <20190416093341.17079-1-pclouds@gmail.com>
From: SZEDER Gábor <szeder.dev@gmail.com>
Use oideq() instead of !oidcmp(), as it is more idiomatic, and might give the compiler more opportunities to optimize.
Patch generated with 'contrib/coccinelle/free.cocci' and Coccinelle v1.0.7 (previous Coccinelle versions don't notice this).
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- builtin/rebase.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c index 868bcd1446..c064909329 100644 --- a/builtin/rebase.c +++ b/builtin/rebase.c @@ -1792,7 +1792,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix) * we just fast-forwarded. */ strbuf_reset(&msg); - if (!oidcmp(&merge_base, &options.orig_head)) { + if (oideq(&merge_base, &options.orig_head)) { printf(_("Fast-forwarded %s to %s.\n"), branch_name, options.onto_name); strbuf_addf(&msg, "rebase finished: %s onto %s",
-- 2.21.0.682.g30d2204636