Re: [PATCH 09/31] commit.c: add repo_get_commit_tree()
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Apr 2, 2019, 15:39 UTC
- Message-ID
- <20190402153953.GL32732@szeder.dev>
- In-Reply-To
- <20190330111927.18645-10-pclouds@gmail.com>
On Sat, Mar 30, 2019 at 06:19:05PM +0700, Nguyễn Thái Ngọc Duy wrote:
Show 20 quoted lines
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> commit.c | 5 +++--
> commit.h | 3 ++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/commit.c b/commit.c
> index a5333c7ac6..f0a5506f04 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -340,7 +340,8 @@ void free_commit_buffer(struct parsed_object_pool *pool, struct commit *commit)
> }
> }
>
> -struct tree *get_commit_tree(const struct commit *commit)
> +struct tree *repo_get_commit_tree(struct repository *r,
> + const struct commit *commit)
> {
> if (commit->maybe_tree || !commit->object.parsed)
> return commit->maybe_tree;By renaming this function this patch triggers Coccinelle and 'commit.cocci', as it specifically whitelists get_commit_tree() as one of the few functions that can legitimately access commit->maybe_tree; for detail see 279ffad17d (coccinelle: avoid wrong transformation suggestions from commit.cocci, 2018-04-30).
Please update 'commit.cocci' accordingly:
diff --git a/contrib/coccinelle/commit.cocci b/contrib/coccinelle/commit.cocci index c49aa558f0..55679cbbed 100644 --- a/contrib/coccinelle/commit.cocci +++ b/contrib/coccinelle/commit.cocci @@ -12,7 +12,7 @@ expression c; // These excluded functions must access c->maybe_tree direcly. @@ -identifier f !~ "^(get_commit_tree|get_commit_tree_in_graph_one|load_tree_for_commit)$"; +identifier f !~ "^(repo_get_commit_tree|get_commit_tree_in_graph_one|load_tree_for_commit)$"; expression c; @@ f(...) {<...