git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 29/31] sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_name

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 30, 2019, 11:19 UTC
Message-ID
<20190330111927.18645-30-pclouds@gmail.com>
In-Reply-To
<20190330111927.18645-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 cache.h     | 4 +++-
 setup.c     | 7 ++++---
 sha1-name.c | 6 ++++--
 3 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/cache.h b/cache.h
index f6e87194d0..3718b3db8a 100644
--- a/cache.h
+++ b/cache.h
@@ -1387,7 +1387,9 @@ extern int get_oid_committish(const char *str, struct object_id *oid);
 extern int get_oid_tree(const char *str, struct object_id *oid);
 extern int get_oid_treeish(const char *str, struct object_id *oid);
 extern int get_oid_blob(const char *str, struct object_id *oid);
-extern void maybe_die_on_misspelt_object_name(const char *name, const char *prefix);
+void maybe_die_on_misspelt_object_name(struct repository *repo,
+				       const char *name,
+				       const char *prefix);
 extern enum get_oid_result get_oid_with_context(struct repository *repo, const char *str,
 				unsigned flags, struct object_id *oid,
 				struct object_context *oc);
diff --git a/setup.c b/setup.c
index d0c958c3b2..8dcb4631f7 100644
--- a/setup.c
+++ b/setup.c
@@ -164,7 +164,8 @@ int check_filename(const char *prefix, const char *arg)
 	die_errno(_("failed to stat '%s'"), arg);
 }
 
-static void NORETURN die_verify_filename(const char *prefix,
+static void NORETURN die_verify_filename(struct repository *r,
+					 const char *prefix,
 					 const char *arg,
 					 int diagnose_misspelt_rev)
 {
@@ -179,7 +180,7 @@ static void NORETURN die_verify_filename(const char *prefix,
 	 * let maybe_die_on_misspelt_object_name() even trigger.
 	 */
 	if (!(arg[0] == ':' && !isalnum(arg[1])))
-		maybe_die_on_misspelt_object_name(arg, prefix);
+		maybe_die_on_misspelt_object_name(r, arg, prefix);
 
 	/* ... or fall back the most general message. */
 	die(_("ambiguous argument '%s': unknown revision or path not in the working tree.\n"
@@ -234,7 +235,7 @@ void verify_filename(const char *prefix,
 		die(_("option '%s' must come before non-option arguments"), arg);
 	if (looks_like_pathspec(arg) || check_filename(prefix, arg))
 		return;
-	die_verify_filename(prefix, arg, diagnose_misspelt_rev);
+	die_verify_filename(the_repository, prefix, arg, diagnose_misspelt_rev);
 }
 
 /*
diff --git a/sha1-name.c b/sha1-name.c
index 953df0d692..b94d381bef 100644
--- a/sha1-name.c
+++ b/sha1-name.c
@@ -1885,11 +1885,13 @@ static enum get_oid_result get_oid_with_context_1(struct repository *repo,
  * exist in 'HEAD'" when given "HEAD:doc", or it may return in which case
  * you have a chance to diagnose the error further.
  */
-void maybe_die_on_misspelt_object_name(const char *name, const char *prefix)
+void maybe_die_on_misspelt_object_name(struct repository *r,
+				       const char *name,
+				       const char *prefix)
 {
 	struct object_context oc;
 	struct object_id oid;
-	get_oid_with_context_1(the_repository, name, GET_OID_ONLY_TO_DIE,
+	get_oid_with_context_1(r, name, GET_OID_ONLY_TO_DIE,
 			       prefix, &oid, &oc);
 }
 
-- 
2.21.0.479.g47ac719cd3
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 31 of 153 in “Kill the_repository in sha1-name.c”
  1. 00/31 Kill the_repository in sha1-name.cNguyễn Thái Ngọc Duy, Mar 30, 2019
  2. 01/31 packfile.c: add repo_approximate_object_count()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  3. 02/31 refs.c: add refs_ref_exists()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  4. 03/31 refs.c: add refs_shorten_unambiguous_ref()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  5. 04/31 refs.c: remove the_repo from substitute_branch_name()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  6. 05/31 refs.c: remove the_repo from expand_ref()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  7. 06/31 refs.c: add repo_dwim_ref()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  8. 07/31 refs.c: add repo_dwim_log()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  9. 08/31 refs.c: remove the_repo from read_ref_at()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  10. 09/31 commit.c: add repo_get_commit_tree()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  11. SZEDER GáborApr 2, 2019
  12. 10/31 sha1-name.c: remove the_repo from sort_ambiguous()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  13. 11/31 sha1-name.c: remove the_repo from find_abbrev_len_packed()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  14. 12/31 sha1-name.c: add repo_find_unique_abbrev_r()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  15. 13/31 sha1-name.c: store and use repo in struct disambiguate_stateNguyễn Thái Ngọc Duy, Mar 30, 2019
  16. 14/31 sha1-name.c: add repo_for_each_abbrev()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  17. 15/31 sha1-name.c: remove the_repo from get_short_oid()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  18. 16/31 sha1-name.c: remove the_repo from interpret_nth_prior_checkout()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  19. 17/31 sha1-name.c: remove the_repo from interpret_branch_mark()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  20. 18/31 sha1-name.c: add repo_interpret_branch_name()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  21. 19/31 sha1-name.c: remove the_repo from get_oid_oneline()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  22. 20/31 sha1-name.c: remove the_repo from get_describe_name()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  23. 21/31 sha1-name.c: remove the_repo from get_oid_basic()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  24. 22/31 sha1-name.c: remove the_repo from get_oid_1()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  25. 23/31 sha1-name.c: remove the_repo from handle_one_ref()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  26. 24/31 sha1-name.c: remove the_repo from diagnose_invalid_index_path()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  27. 25/31 sha1-name.c: remove the_repo from resolve_relative_path()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  28. 26/31 sha1-name.c: remove the_repo from get_oid_with_context_1()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  29. 27/31 sha1-name.c: add repo_get_oid()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  30. 28/31 submodule-config.c: use repo_get_oid for reading .gitmodulesNguyễn Thái Ngọc Duy, Mar 30, 2019
  31. 29/31 sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_nameNguyễn Thái Ngọc Duy, Mar 30, 2019
  32. 30/31 sha1-name.c: remove the_repo from other get_oid_*Nguyễn Thái Ngọc Duy, Mar 30, 2019
  33. 31/31 sha1-name.c: remove the_repo from get_oid_mb()Nguyễn Thái Ngọc Duy, Mar 30, 2019
  34. 00/32 nd/sha1-name-c-wo-the-repository updatesNguyễn Thái Ngọc Duy, Apr 3, 2019
  35. 01/32 rebase: 'make coccicheck' cleanupNguyễn Thái Ngọc Duy, Apr 3, 2019
  36. SZEDER GáborApr 4, 2019
  37. Duy NguyenApr 5, 2019
  38. SZEDER GáborApr 9, 2019
  39. 02/32 packfile.c: add repo_approximate_object_count()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  40. 03/32 refs.c: add refs_ref_exists()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  41. 04/32 refs.c: add refs_shorten_unambiguous_ref()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  42. 05/32 refs.c: remove the_repo from substitute_branch_name()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  43. 06/32 refs.c: remove the_repo from expand_ref()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  44. 07/32 refs.c: add repo_dwim_ref()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  45. 08/32 refs.c: add repo_dwim_log()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  46. 09/32 refs.c: remove the_repo from read_ref_at()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  47. 10/32 commit.c: add repo_get_commit_tree()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  48. SZEDER GáborApr 4, 2019
  49. Duy NguyenApr 5, 2019
  50. Johannes SchindelinApr 5, 2019
  51. 11/32 sha1-name.c: remove the_repo from sort_ambiguous()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  52. 12/32 sha1-name.c: remove the_repo from find_abbrev_len_packed()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  53. 13/32 sha1-name.c: add repo_find_unique_abbrev_r()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  54. 14/32 sha1-name.c: store and use repo in struct disambiguate_stateNguyễn Thái Ngọc Duy, Apr 3, 2019
  55. 15/32 sha1-name.c: add repo_for_each_abbrev()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  56. 16/32 sha1-name.c: remove the_repo from get_short_oid()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  57. 17/32 sha1-name.c: remove the_repo from interpret_nth_prior_checkout()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  58. 18/32 sha1-name.c: remove the_repo from interpret_branch_mark()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  59. 19/32 sha1-name.c: add repo_interpret_branch_name()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  60. 20/32 sha1-name.c: remove the_repo from get_oid_oneline()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  61. 21/32 sha1-name.c: remove the_repo from get_describe_name()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  62. 22/32 sha1-name.c: remove the_repo from get_oid_basic()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  63. 23/32 sha1-name.c: remove the_repo from get_oid_1()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  64. 24/32 sha1-name.c: remove the_repo from handle_one_ref()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  65. 25/32 sha1-name.c: remove the_repo from diagnose_invalid_index_path()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  66. 26/32 sha1-name.c: remove the_repo from resolve_relative_path()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  67. 27/32 sha1-name.c: remove the_repo from get_oid_with_context_1()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  68. 28/32 sha1-name.c: add repo_get_oid()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  69. 29/32 submodule-config.c: use repo_get_oid for reading .gitmodulesNguyễn Thái Ngọc Duy, Apr 3, 2019
  70. 30/32 sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_nameNguyễn Thái Ngọc Duy, Apr 3, 2019
  71. 31/32 sha1-name.c: remove the_repo from other get_oid_*Nguyễn Thái Ngọc Duy, Apr 3, 2019
  72. 32/32 sha1-name.c: remove the_repo from get_oid_mb()Nguyễn Thái Ngọc Duy, Apr 3, 2019
  73. 00/33 nd/sha1-name-c-wo-the-repository updatesNguyễn Thái Ngọc Duy, Apr 6, 2019
  74. 01/33 builtin rebase: use FREE_AND_NULLNguyễn Thái Ngọc Duy, Apr 6, 2019
  75. 02/33 builtin rebase: use oideq()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  76. 03/33 packfile.c: add repo_approximate_object_count()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  77. 04/33 refs.c: add refs_ref_exists()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  78. 05/33 refs.c: add refs_shorten_unambiguous_ref()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  79. 06/33 refs.c: remove the_repo from substitute_branch_name()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  80. 07/33 refs.c: remove the_repo from expand_ref()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  81. 08/33 refs.c: add repo_dwim_ref()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  82. 09/33 refs.c: add repo_dwim_log()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  83. 10/33 refs.c: remove the_repo from read_ref_at()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  84. 11/33 commit.c: add repo_get_commit_tree()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  85. 12/33 sha1-name.c: remove the_repo from sort_ambiguous()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  86. 13/33 sha1-name.c: remove the_repo from find_abbrev_len_packed()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  87. 14/33 sha1-name.c: add repo_find_unique_abbrev_r()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  88. 15/33 sha1-name.c: store and use repo in struct disambiguate_stateNguyễn Thái Ngọc Duy, Apr 6, 2019
  89. 16/33 sha1-name.c: add repo_for_each_abbrev()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  90. 17/33 sha1-name.c: remove the_repo from get_short_oid()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  91. 18/33 sha1-name.c: remove the_repo from interpret_nth_prior_checkout()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  92. 19/33 sha1-name.c: remove the_repo from interpret_branch_mark()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  93. 20/33 sha1-name.c: add repo_interpret_branch_name()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  94. 21/33 sha1-name.c: remove the_repo from get_oid_oneline()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  95. 22/33 sha1-name.c: remove the_repo from get_describe_name()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  96. 23/33 sha1-name.c: remove the_repo from get_oid_basic()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  97. 24/33 sha1-name.c: remove the_repo from get_oid_1()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  98. 25/33 sha1-name.c: remove the_repo from handle_one_ref()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  99. 26/33 sha1-name.c: remove the_repo from diagnose_invalid_index_path()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  100. 27/33 sha1-name.c: remove the_repo from resolve_relative_path()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  101. 28/33 sha1-name.c: remove the_repo from get_oid_with_context_1()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  102. 29/33 sha1-name.c: add repo_get_oid()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  103. 30/33 submodule-config.c: use repo_get_oid for reading .gitmodulesNguyễn Thái Ngọc Duy, Apr 6, 2019
  104. 31/33 sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_nameNguyễn Thái Ngọc Duy, Apr 6, 2019
  105. 32/33 sha1-name.c: remove the_repo from other get_oid_*Nguyễn Thái Ngọc Duy, Apr 6, 2019
  106. 33/33 sha1-name.c: remove the_repo from get_oid_mb()Nguyễn Thái Ngọc Duy, Apr 6, 2019
  107. Johannes SchindelinApr 10, 2019
  108. Duy NguyenApr 11, 2019
  109. Johannes SchindelinApr 11, 2019
  110. SZEDER GáborApr 11, 2019
  111. SZEDER GáborApr 11, 2019
  112. SZEDER GáborApr 12, 2019
  113. Johannes SchindelinApr 12, 2019
  114. 11/33 commit.c: add repo_get_commit_tree()Nguyễn Thái Ngọc Duy, Apr 13, 2019
  115. SZEDER GáborApr 13, 2019
  116. Johannes SchindelinApr 15, 2019
  117. SZEDER GáborApr 13, 2019
  118. Duy NguyenApr 13, 2019
  119. 00/34 nd/sha1-name-c-wo-the-repository updatesNguyễn Thái Ngọc Duy, Apr 16, 2019
  120. 01/34 builtin rebase: use FREE_AND_NULLNguyễn Thái Ngọc Duy, Apr 16, 2019
  121. 02/34 builtin rebase: use oideq()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  122. 03/34 packfile.c: add repo_approximate_object_count()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  123. 04/34 refs.c: add refs_ref_exists()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  124. 05/34 refs.c: add refs_shorten_unambiguous_ref()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  125. 06/34 refs.c: remove the_repo from substitute_branch_name()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  126. 07/34 refs.c: remove the_repo from expand_ref()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  127. 08/34 refs.c: add repo_dwim_ref()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  128. 09/34 refs.c: add repo_dwim_log()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  129. 10/34 refs.c: remove the_repo from read_ref_at()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  130. 11/34 commit.cocci: refactor code, avoid double rewriteNguyễn Thái Ngọc Duy, Apr 16, 2019
  131. 12/34 commit.c: add repo_get_commit_tree()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  132. 13/34 sha1-name.c: remove the_repo from sort_ambiguous()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  133. 14/34 sha1-name.c: remove the_repo from find_abbrev_len_packed()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  134. 15/34 sha1-name.c: add repo_find_unique_abbrev_r()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  135. 16/34 sha1-name.c: store and use repo in struct disambiguate_stateNguyễn Thái Ngọc Duy, Apr 16, 2019
  136. 17/34 sha1-name.c: add repo_for_each_abbrev()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  137. 18/34 sha1-name.c: remove the_repo from get_short_oid()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  138. 19/34 sha1-name.c: remove the_repo from interpret_nth_prior_checkout()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  139. 20/34 sha1-name.c: remove the_repo from interpret_branch_mark()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  140. 21/34 sha1-name.c: add repo_interpret_branch_name()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  141. 22/34 sha1-name.c: remove the_repo from get_oid_oneline()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  142. 23/34 sha1-name.c: remove the_repo from get_describe_name()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  143. 24/34 sha1-name.c: remove the_repo from get_oid_basic()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  144. 25/34 sha1-name.c: remove the_repo from get_oid_1()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  145. 26/34 sha1-name.c: remove the_repo from handle_one_ref()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  146. 27/34 sha1-name.c: remove the_repo from diagnose_invalid_index_path()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  147. 28/34 sha1-name.c: remove the_repo from resolve_relative_path()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  148. 29/34 sha1-name.c: remove the_repo from get_oid_with_context_1()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  149. 30/34 sha1-name.c: add repo_get_oid()Nguyễn Thái Ngọc Duy, Apr 16, 2019
  150. 31/34 submodule-config.c: use repo_get_oid for reading .gitmodulesNguyễn Thái Ngọc Duy, Apr 16, 2019
  151. 32/34 sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_nameNguyễn Thái Ngọc Duy, Apr 16, 2019
  152. 33/34 sha1-name.c: remove the_repo from other get_oid_*Nguyễn Thái Ngọc Duy, Apr 16, 2019
  153. 34/34 sha1-name.c: remove the_repo from get_oid_mb()Nguyễn Thái Ngọc Duy, Apr 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.