Re: [PATCH v2 09/13] server-info: simplify cleanup in parse_pack_def()

From: Jeff King <peff@peff.net>
Date: Apr 5, 2019, 18:16 UTC
Message-ID: <20190405181630.GA2284@sigill.intra.peff.net>
In-Reply-To: <20190405181313.GI32243@sigill.intra.peff.net>

On Fri, Apr 05, 2019 at 02:13:13PM -0400, Jeff King wrote:

Show 5 quoted lines

> Subject: server-info: simplify cleanup in parse_pack_def()
> We have two exits from the function: either we jump to the out_stale
> label or not. But in both exits we repeat our cleanup, and the only
> difference is our return value. Let's just use a variable for the return
> value to avoid repeating ourselves.

The subject name is misleading here. The change is actually in read_pack_info_file(), which sees an error when calling parse_pack_def().

Probably not worth a re-roll by itself.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.