git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 02/20] diff-parseopt: convert --patience

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 5, 2019, 12:30 UTC
Message-ID
<20190305123026.7266-3-pclouds@gmail.com>
In-Reply-To
<20190305123026.7266-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 diff.c | 37 +++++++++++++++++++++++++------------
 1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/diff.c b/diff.c
index c4cd84f1b3..7899c7cc06 100644
--- a/diff.c
+++ b/diff.c
@@ -4960,6 +4960,26 @@ static enum parse_opt_result diff_opt_output(struct parse_opt_ctx_t *ctx,
 	return 0;
 }
 
+static int diff_opt_patience(const struct option *opt,
+			     const char *arg, int unset)
+{
+	struct diff_options *options = opt->value;
+	int i;
+
+	BUG_ON_OPT_NEG(unset);
+	BUG_ON_OPT_ARG(arg);
+	options->xdl_opts = DIFF_WITH_ALG(options, PATIENCE_DIFF);
+	/*
+	 * Both --patience and --anchored use PATIENCE_DIFF
+	 * internally, so remove any anchors previously
+	 * specified.
+	 */
+	for (i = 0; i < options->anchors_nr; i++)
+		free(options->anchors[i]);
+	options->anchors_nr = 0;
+	return 0;
+}
+
 static int diff_opt_relative(const struct option *opt,
 			     const char *arg, int unset)
 {
@@ -5127,6 +5147,10 @@ static void prep_parse_options(struct diff_options *options)
 		OPT_BIT(0, "indent-heuristic", &options->xdl_opts,
 			N_("heuristic to shift diff hunk boundaries for easy reading"),
 			XDF_INDENT_HEURISTIC),
+		OPT_CALLBACK_F(0, "patience", options, NULL,
+			       N_("generate diff using the \"patience diff\" algorithm"),
+			       PARSE_OPT_NONEG | PARSE_OPT_NOARG,
+			       diff_opt_patience),
 
 		OPT_GROUP(N_("Diff other options")),
 		OPT_CALLBACK_F(0, "relative", options, N_("<prefix>"),
@@ -5165,18 +5189,7 @@ int diff_opt_parse(struct diff_options *options,
 		return ac;
 
 	/* xdiff options */
-	if (!strcmp(arg, "--patience")) {
-		int i;
-		options->xdl_opts = DIFF_WITH_ALG(options, PATIENCE_DIFF);
-		/*
-		 * Both --patience and --anchored use PATIENCE_DIFF
-		 * internally, so remove any anchors previously
-		 * specified.
-		 */
-		for (i = 0; i < options->anchors_nr; i++)
-			free(options->anchors[i]);
-		options->anchors_nr = 0;
-	} else if (!strcmp(arg, "--histogram"))
+	if (!strcmp(arg, "--histogram"))
 		options->xdl_opts = DIFF_WITH_ALG(options, HISTOGRAM_DIFF);
 	else if ((argcount = parse_long_opt("diff-algorithm", av, &optarg))) {
 		long value = parse_algorithm_value(optarg);
-- 
2.21.0.rc1.337.gdf7f8d0522
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 3 of 23 in “nd/diff-parseopt part 3”
  1. 00/20 nd/diff-parseopt part 3Nguyễn Thái Ngọc Duy, Mar 5, 2019
  2. 01/20 diff-parseopt: convert --[no-]indent-heuristicNguyễn Thái Ngọc Duy, Mar 5, 2019
  3. 02/20 diff-parseopt: convert --patienceNguyễn Thái Ngọc Duy, Mar 5, 2019
  4. 03/20 diff-parseopt: convert --histogramNguyễn Thái Ngọc Duy, Mar 5, 2019
  5. 04/20 diff-parseopt: convert --diff-algorithmNguyễn Thái Ngọc Duy, Mar 5, 2019
  6. 05/20 diff-parseopt: convert --anchoredNguyễn Thái Ngọc Duy, Mar 5, 2019
  7. 06/20 diff-parseopt: convert --binaryNguyễn Thái Ngọc Duy, Mar 5, 2019
  8. 07/20 diff-parseopt: convert --full-indexNguyễn Thái Ngọc Duy, Mar 5, 2019
  9. 08/20 diff-parseopt: convert -a|--textNguyễn Thái Ngọc Duy, Mar 5, 2019
  10. 09/20 diff-parseopt: convert -RNguyễn Thái Ngọc Duy, Mar 5, 2019
  11. 10/20 diff-parseopt: convert --[no-]followNguyễn Thái Ngọc Duy, Mar 5, 2019
  12. 11/20 diff-parseopt: convert --[no-]colorNguyễn Thái Ngọc Duy, Mar 5, 2019
  13. 12/20 diff-parseopt: convert --word-diffNguyễn Thái Ngọc Duy, Mar 5, 2019
  14. 13/20 diff-parseopt: convert --word-diff-regexNguyễn Thái Ngọc Duy, Mar 5, 2019
  15. 14/20 diff-parseopt: convert --color-wordsNguyễn Thái Ngọc Duy, Mar 5, 2019
  16. 15/20 diff-parseopt: convert --exit-codeNguyễn Thái Ngọc Duy, Mar 5, 2019
  17. 16/20 diff-parseopt: convert --quietNguyễn Thái Ngọc Duy, Mar 5, 2019
  18. Eric SunshineMar 5, 2019
  19. Duy NguyenMar 6, 2019
  20. 17/20 diff-parseopt: convert --ext-diffNguyễn Thái Ngọc Duy, Mar 5, 2019
  21. 18/20 diff-parseopt: convert --textconvNguyễn Thái Ngọc Duy, Mar 5, 2019
  22. 19/20 diff-parseopt: convert --ignore-submodulesNguyễn Thái Ngọc Duy, Mar 5, 2019
  23. 20/20 diff-parseopt: convert --submoduleNguyễn Thái Ngọc Duy, Mar 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.