git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 19/20] diff-parseopt: convert --ignore-submodules

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 5, 2019, 12:30 UTC
Message-ID
<20190305123026.7266-20-pclouds@gmail.com>
In-Reply-To
<20190305123026.7266-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 diff.c | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/diff.c b/diff.c
index a27bca527d..6fd6106963 100644
--- a/diff.c
+++ b/diff.c
@@ -5013,6 +5013,19 @@ static int diff_opt_follow(const struct option *opt,
 	return 0;
 }
 
+static int diff_opt_ignore_submodules(const struct option *opt,
+				      const char *arg, int unset)
+{
+	struct diff_options *options = opt->value;
+
+	BUG_ON_OPT_NEG(unset);
+	if (!arg)
+		arg = "all";
+	options->flags.override_submodule_config = 1;
+	handle_ignore_submodules_arg(options, arg);
+	return 0;
+}
+
 static enum parse_opt_result diff_opt_output(struct parse_opt_ctx_t *ctx,
 					     const struct option *opt,
 					     const char *arg, int unset)
@@ -5321,6 +5334,10 @@ static void prep_parse_options(struct diff_options *options)
 		OPT_CALLBACK_F(0, "textconv", options, NULL,
 			       N_("run external text conversion filters when comparing binary files"),
 			       PARSE_OPT_NOARG, diff_opt_textconv),
+		OPT_CALLBACK_F(0, "ignore-submodules", options, N_("<when>"),
+			       N_("ignore changes to submodules in the diff generation"),
+			       PARSE_OPT_NONEG | PARSE_OPT_OPTARG,
+			       diff_opt_ignore_submodules),
 		{ OPTION_CALLBACK, 0, "output", options, N_("<file>"),
 		  N_("Output to a specific file"),
 		  PARSE_OPT_NONEG, NULL, 0, diff_opt_output },
@@ -5370,9 +5387,6 @@ int diff_opt_parse(struct diff_options *options,
 		if (cm & COLOR_MOVED_WS_ERROR)
 			return -1;
 		options->color_moved_ws_handling = cm;
-	} else if (skip_to_optional_arg_default(arg, "--ignore-submodules", &arg, "all")) {
-		options->flags.override_submodule_config = 1;
-		handle_ignore_submodules_arg(options, arg);
 	} else if (skip_to_optional_arg_default(arg, "--submodule", &arg, "log"))
 		return parse_submodule_opt(options, arg);
 	else if (skip_prefix(arg, "--ws-error-highlight=", &arg))
-- 
2.21.0.rc1.337.gdf7f8d0522
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 22 of 23 in “nd/diff-parseopt part 3”
  1. 00/20 nd/diff-parseopt part 3Nguyễn Thái Ngọc Duy, Mar 5, 2019
  2. 01/20 diff-parseopt: convert --[no-]indent-heuristicNguyễn Thái Ngọc Duy, Mar 5, 2019
  3. 02/20 diff-parseopt: convert --patienceNguyễn Thái Ngọc Duy, Mar 5, 2019
  4. 03/20 diff-parseopt: convert --histogramNguyễn Thái Ngọc Duy, Mar 5, 2019
  5. 04/20 diff-parseopt: convert --diff-algorithmNguyễn Thái Ngọc Duy, Mar 5, 2019
  6. 05/20 diff-parseopt: convert --anchoredNguyễn Thái Ngọc Duy, Mar 5, 2019
  7. 06/20 diff-parseopt: convert --binaryNguyễn Thái Ngọc Duy, Mar 5, 2019
  8. 07/20 diff-parseopt: convert --full-indexNguyễn Thái Ngọc Duy, Mar 5, 2019
  9. 08/20 diff-parseopt: convert -a|--textNguyễn Thái Ngọc Duy, Mar 5, 2019
  10. 09/20 diff-parseopt: convert -RNguyễn Thái Ngọc Duy, Mar 5, 2019
  11. 10/20 diff-parseopt: convert --[no-]followNguyễn Thái Ngọc Duy, Mar 5, 2019
  12. 11/20 diff-parseopt: convert --[no-]colorNguyễn Thái Ngọc Duy, Mar 5, 2019
  13. 12/20 diff-parseopt: convert --word-diffNguyễn Thái Ngọc Duy, Mar 5, 2019
  14. 13/20 diff-parseopt: convert --word-diff-regexNguyễn Thái Ngọc Duy, Mar 5, 2019
  15. 14/20 diff-parseopt: convert --color-wordsNguyễn Thái Ngọc Duy, Mar 5, 2019
  16. 15/20 diff-parseopt: convert --exit-codeNguyễn Thái Ngọc Duy, Mar 5, 2019
  17. 16/20 diff-parseopt: convert --quietNguyễn Thái Ngọc Duy, Mar 5, 2019
  18. Eric SunshineMar 5, 2019
  19. Duy NguyenMar 6, 2019
  20. 17/20 diff-parseopt: convert --ext-diffNguyễn Thái Ngọc Duy, Mar 5, 2019
  21. 18/20 diff-parseopt: convert --textconvNguyễn Thái Ngọc Duy, Mar 5, 2019
  22. 19/20 diff-parseopt: convert --ignore-submodulesNguyễn Thái Ngọc Duy, Mar 5, 2019
  23. 20/20 diff-parseopt: convert --submoduleNguyễn Thái Ngọc Duy, Mar 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.