git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 14/20] diff-parseopt: convert --color-words

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 5, 2019, 12:30 UTC
Message-ID
<20190305123026.7266-15-pclouds@gmail.com>
In-Reply-To
<20190305123026.7266-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 diff.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/diff.c b/diff.c
index 634981723b..5180c2f5a9 100644
--- a/diff.c
+++ b/diff.c
@@ -4901,6 +4901,18 @@ static int diff_opt_char(const struct option *opt,
 	return 0;
 }
 
+static int diff_opt_color_words(const struct option *opt,
+				const char *arg, int unset)
+{
+	struct diff_options *options = opt->value;
+
+	BUG_ON_OPT_NEG(unset);
+	options->use_color = 1;
+	options->word_diff = DIFF_WORDS_COLOR;
+	options->word_regex = arg;
+	return 0;
+}
+
 static int diff_opt_compact_summary(const struct option *opt,
 				    const char *arg, int unset)
 {
@@ -5272,6 +5284,9 @@ static void prep_parse_options(struct diff_options *options)
 		OPT_CALLBACK_F(0, "word-diff-regex", options, N_("<regex>"),
 			       N_("use <regex> to decide what a word is"),
 			       PARSE_OPT_NONEG, diff_opt_word_diff_regex),
+		OPT_CALLBACK_F(0, "color-words", options, N_("<regex>"),
+			       N_("equivalent to --word-diff=color --word-diff-regex=<regex>"),
+			       PARSE_OPT_NONEG | PARSE_OPT_OPTARG, diff_opt_color_words),
 
 		OPT_GROUP(N_("Diff other options")),
 		OPT_CALLBACK_F(0, "relative", options, N_("<prefix>"),
@@ -5331,11 +5346,7 @@ int diff_opt_parse(struct diff_options *options,
 		if (cm & COLOR_MOVED_WS_ERROR)
 			return -1;
 		options->color_moved_ws_handling = cm;
-	} else if (skip_to_optional_arg_default(arg, "--color-words", &options->word_regex, NULL)) {
-		options->use_color = 1;
-		options->word_diff = DIFF_WORDS_COLOR;
-	}
-	else if (!strcmp(arg, "--exit-code"))
+	} else if (!strcmp(arg, "--exit-code"))
 		options->flags.exit_with_status = 1;
 	else if (!strcmp(arg, "--quiet"))
 		options->flags.quick = 1;
-- 
2.21.0.rc1.337.gdf7f8d0522
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 15 of 23 in “nd/diff-parseopt part 3”
  1. 00/20 nd/diff-parseopt part 3Nguyễn Thái Ngọc Duy, Mar 5, 2019
  2. 01/20 diff-parseopt: convert --[no-]indent-heuristicNguyễn Thái Ngọc Duy, Mar 5, 2019
  3. 02/20 diff-parseopt: convert --patienceNguyễn Thái Ngọc Duy, Mar 5, 2019
  4. 03/20 diff-parseopt: convert --histogramNguyễn Thái Ngọc Duy, Mar 5, 2019
  5. 04/20 diff-parseopt: convert --diff-algorithmNguyễn Thái Ngọc Duy, Mar 5, 2019
  6. 05/20 diff-parseopt: convert --anchoredNguyễn Thái Ngọc Duy, Mar 5, 2019
  7. 06/20 diff-parseopt: convert --binaryNguyễn Thái Ngọc Duy, Mar 5, 2019
  8. 07/20 diff-parseopt: convert --full-indexNguyễn Thái Ngọc Duy, Mar 5, 2019
  9. 08/20 diff-parseopt: convert -a|--textNguyễn Thái Ngọc Duy, Mar 5, 2019
  10. 09/20 diff-parseopt: convert -RNguyễn Thái Ngọc Duy, Mar 5, 2019
  11. 10/20 diff-parseopt: convert --[no-]followNguyễn Thái Ngọc Duy, Mar 5, 2019
  12. 11/20 diff-parseopt: convert --[no-]colorNguyễn Thái Ngọc Duy, Mar 5, 2019
  13. 12/20 diff-parseopt: convert --word-diffNguyễn Thái Ngọc Duy, Mar 5, 2019
  14. 13/20 diff-parseopt: convert --word-diff-regexNguyễn Thái Ngọc Duy, Mar 5, 2019
  15. 14/20 diff-parseopt: convert --color-wordsNguyễn Thái Ngọc Duy, Mar 5, 2019
  16. 15/20 diff-parseopt: convert --exit-codeNguyễn Thái Ngọc Duy, Mar 5, 2019
  17. 16/20 diff-parseopt: convert --quietNguyễn Thái Ngọc Duy, Mar 5, 2019
  18. Eric SunshineMar 5, 2019
  19. Duy NguyenMar 6, 2019
  20. 17/20 diff-parseopt: convert --ext-diffNguyễn Thái Ngọc Duy, Mar 5, 2019
  21. 18/20 diff-parseopt: convert --textconvNguyễn Thái Ngọc Duy, Mar 5, 2019
  22. 19/20 diff-parseopt: convert --ignore-submodulesNguyễn Thái Ngọc Duy, Mar 5, 2019
  23. 20/20 diff-parseopt: convert --submoduleNguyễn Thái Ngọc Duy, Mar 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.