Re: [PATCH] add_to_index(): convert forgotten HASH_RENORMALIZE check

From: Jeff King <peff@peff.net>
Date: Feb 7, 2019, 21:00 UTC
Message-ID: <20190207210009.GA30825@sigill.intra.peff.net>
In-Reply-To: <20190207041802.ai25fc64sqfg2h66@tb-raspi4>

On Thu, Feb 07, 2019 at 04:18:02AM +0000, Torsten Bögershausen wrote:

Show 11 quoted lines

> And trying to answer an older question:
> 
> >>>The reason appears to be wrong bit mask usage
> >>>#define ADD_CACHE_IGNORE_ERRORS    4
> >>>and
> >>>#define HASH_RENORMALIZE  4
> 
> What if we had renamed "flags" like this ?
> [...]
> -int add_to_index(struct index_state *istate, const char *path, struct stat *st, int flags)
> +int add_to_index(struct index_state *istate, const char *path, struct stat *st, int add_cache_flags)

Yes, changing the name of the variable in the original patch would have caught this case. I don't know if it is worth doing now or not (the code as it is now seems pretty clear to me, but of course I've looked at it a lot lately).

-Peff