git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t0025 flakey?

From
Torsten Bögershausen <tboegi@web.de>
Date
Feb 6, 2019, 17:15 UTC
Message-ID
<20190206171517.s5lskawpdodc74ui@tb-raspi4>
In-Reply-To
<nycvar.QRO.7.76.6.1902061450280.41@tvgsbejvaqbjf.bet>
On Wed, Feb 06, 2019 at 02:52:53PM +0100, Johannes Schindelin wrote:
Show 58 quoted lines
> Hi Gábor,
>
> On Wed, 6 Feb 2019, SZEDER Gábor wrote:
>
> > On Wed, Feb 06, 2019 at 11:25:38AM +0100, Johannes Schindelin wrote:
> >
> > > at first I thought that those intermittent test failures were limited
> > > to Windows, but they are not: I can see it now in a build on 32-bit
> > > Linux.
> > > Full logs here:
> > >
> > > https://dev.azure.com/gitgitgadget/git/_build/results?buildId=1032&_a=summary&view=ms.vss-test-web.build-test-results-tab
> > >
> > > Excerpt from the failing test case:
> > >
> > > -- snip --
> > > not ok 2 - renormalize CRLF in repo
> > >  expecting success:
> > > 	echo "*.txt text=auto" >.gitattributes &&
> > > 	git add --renormalize "*.txt" &&
> > > 	cat >expect <<-\EOF &&
> > > 	i/lf w/crlf attr/text=auto CRLF.txt
> > > 	i/lf w/lf attr/text=auto LF.txt
> > > 	i/lf w/mixed attr/text=auto CRLF_mix_LF.txt
> > > 	EOF
> > > 	git ls-files --eol |
> > > 	sed -e "s/	/ /g" -e "s/  */ /g" |
> > > 	sort >actual &&
> > > 	test_cmp expect actual
> > >
> > > + echo *.txt text=auto
> > > + git add --renormalize *.txt
> > > + cat
> > > + sort
> > > + sed -e s/	/ /g -e s/  */ /g
> > > + git ls-files --eol
> > > + test_cmp expect actual
> > > + diff -u expect actual
> > > --- expect	2019-02-06 09:39:42.080733629 +0000
> > > +++ actual	2019-02-06 09:39:42.088733629 +0000
> > > @@ -1,3 +1,3 @@
> > > -i/lf w/crlf attr/text=auto CRLF.txt
> > > +i/crlf w/crlf attr/text=auto CRLF.txt
> > >  i/lf w/lf attr/text=auto LF.txt
> > > -i/lf w/mixed attr/text=auto CRLF_mix_LF.txt
> > > +i/mixed w/mixed attr/text=auto CRLF_mix_LF.txt
> > > error: last command exited with $?=1
> > > -- snap --
> > >
> > > Any ideas?
> >
> > I reported this and Peff looked into it on the way to Git Merge, but
> > not working solution yet.
> >
> > https://public-inbox.org/git/20190129225121.GD1895@sigill.intra.peff.net/T/#u
>
> Thank you!
> Dscho

I shortly looked into the pointers here - Is t0025 flaky after the fix from Peff:

[PATCH] add: use separate ADD_CACHE_RENORMALIZE flag

Or has it always been shaky ? Does anybody know ?

Previous: Johannes SchindelinNext: SZEDER Gábor
Message 4 of 14 in “t0025 flakey?”
  1. Johannes SchindelinFeb 6, 2019
  2. SZEDER GáborFeb 6, 2019
  3. Johannes SchindelinFeb 6, 2019
  4. Torsten BögershausenFeb 6, 2019
  5. SZEDER GáborFeb 6, 2019
  6. Randall S. BeckerFeb 6, 2019
  7. Randall S. BeckerFeb 7, 2019
  8. Junio C HamanoFeb 7, 2019
  9. SZEDER GáborFeb 7, 2019
  10. Randall S. BeckerFeb 8, 2019
  11. add_to_index(): convert forgotten HASH_RENORMALIZE checkJeff King, Feb 7, 2019
  12. Torsten BögershausenFeb 7, 2019
  13. Jeff KingFeb 7, 2019
  14. Johannes SchindelinFeb 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.