Re: [PATCH] t5562: do not reuse output files

From: Max Kirillov <max@max630.net>
Date: Nov 24, 2018, 07:58 UTC
Message-ID: <20181124075838.GG5348@jessie.local>
In-Reply-To: <xmqq7eh23ojc.fsf@gitster-ct.c.googlers.com>

On Sat, Nov 24, 2018 at 04:47:19PM +0900, Junio C Hamano wrote:

Show 5 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> a better workaround might be to write into unique output filenames
> (act1.out, act2.out, etc.); that way, you do not have to worry about
> the output file for the next request getting clobbered by a stale
> process handling the previous request.

Yes I agree

> But at the same time,
> wouldn't this suggest that the test or the previous request may see
> an incomplete output,

Yes it may miss the child's message. But in this case of failed http-backend process, there should be already one "fatal:" message in the act.err from the parent, and missing another one does not change the outcome.