Re: [PATCH] t5562: do not reuse output files

From: Jeff King <peff@peff.net>
Date: Nov 24, 2018, 12:14 UTC
Message-ID: <20181124121445.GD19257@sigill.intra.peff.net>
In-Reply-To: <xmqq7eh23ojc.fsf@gitster-ct.c.googlers.com>

On Sat, Nov 24, 2018 at 04:47:19PM +0900, Junio C Hamano wrote:

> I do agree that forcing the parent to wait, like you described in
> the comment, would be far more preferrable, [...]

Stray processes can sometimes have funny effects on an outer test harness, too. E.g., I think I've seen hangs running t5562 under prove, because some process is holding open a pipe descriptor. This would probably fix that, too.

> but until that happens,[...]

But if we can't do that immediately for some reason, I do agree with everything else you said here. ;)

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.