Re: insteadOf and git-request-pull output

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Nov 16, 2018, 11:56 UTC
Message-ID: <20181116115639.GO890086@genre.crustytoothpaste.net>
In-Reply-To: <20181115182826.GB25806@pure.paranoia.local>

On Thu, Nov 15, 2018 at 01:28:26PM -0500, Konstantin Ryabitsev wrote:

Show 17 quoted lines

> Hi, all:
> 
> Looks like setting url.insteadOf rules alters the output of
> git-request-pull. I'm not sure that's the intended use of insteadOf,
> which is supposed to replace URLs for local use, not to expose them
> publicly (but I may be wrong). E.g.:
> 
> $ git request-pull HEAD^ git://foo.example.com/example | grep example
>   git://foo.example.com/example
> 
> $ git config url.ssh://bar.insteadOf git://foo
> 
> $ git request-pull HEAD^ git://foo.example.com/example | grep example
>   ssh://bar.example.com/example
> 
> I think that if we use the "principle of least surprise," insteadOf
> rules shouldn't be applied for git-request-pull URLs.

I'd like to point out a different use that may change your view. I have an insteadOf alias, gh:, that points to GitHub. Performing the rewrite is definitely the right thing to do, since other users may not have my alias available.

I agree that in your case, a rewrite seems less appropriate, but I think we should only skip the rewrite if the value already matches a valid URL.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204