Re: insteadOf and git-request-pull output
- From
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
- Date
- Nov 15, 2018, 19:26 UTC
- Message-ID
- <20181115192624.GA18204@pure.paranoia.local>
- In-Reply-To
- <87pnv6189j.fsf@evledraar.gmail.com>
On Thu, Nov 15, 2018 at 07:54:32PM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 8 quoted lines
> > I think that if we use the "principle of least surprise," insteadOf > > rules shouldn't be applied for git-request-pull URLs. > > I haven't used request-pull so I don't have much of an opinion on this, > but do you think the same applies to 'git remote get-url <remote>'? > > I.e. should it also show the original unmunged URL, or the munged one as > it does now?
I don't know, maybe both? As opposed to git-request-pull, this is not exposing the insteadOf URL to someone other than the person who set it up, so even if it does return the munged URL, it wouldn't be unexpected.
-K