insteadOf and git-request-pull output
- From
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
- Date
- Nov 15, 2018, 18:28 UTC
- Message-ID
- <20181115182826.GB25806@pure.paranoia.local>
Hi, all:
Looks like setting url.insteadOf rules alters the output of git-request-pull. I'm not sure that's the intended use of insteadOf, which is supposed to replace URLs for local use, not to expose them publicly (but I may be wrong). E.g.:
$ git request-pull HEAD^ git://foo.example.com/example | grep example git://foo.example.com/example
$ git config url.ssh://bar.insteadOf git://foo
$ git request-pull HEAD^ git://foo.example.com/example | grep example ssh://bar.example.com/example
I think that if we use the "principle of least surprise," insteadOf rules shouldn't be applied for git-request-pull URLs.
Best, -K