git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.mak.dev: add -Wformat

From
Jeff King <peff@peff.net>
Date
Oct 12, 2018, 19:11 UTC
Message-ID
<20181012191134.GE4917@sigill.intra.peff.net>
In-Reply-To
<20181012185450.GB52080@aiede.svl.corp.google.com>
On Fri, Oct 12, 2018 at 11:54:50AM -0700, Jonathan Nieder wrote:
Show 5 quoted lines
> > I'm not opposed to making config.mak.dev a bit more redundant to handle
> > this case, but we'd probably want to include all of -Wall, since it
> > contains many other warnings we'd want to make sure are enabled.
> 
> Do you mean putting -Wall instead of -Wformat?
Yes.
> Should we add -Wextra too?  From a quick test, it seems to build okay.

We already do (though we have to then manually disable a few warnings that we're not ready for -- see config.mak.dev).

-Peff
Previous: Jonathan NiederNext: Thomas Gummerer
Message 4 of 11 in “config.mak.dev: add -Wformat”
  1. config.mak.dev: add -WformatThomas Gummerer, Oct 12, 2018
  2. Jeff KingOct 12, 2018
  3. Jonathan NiederOct 12, 2018
  4. Jeff KingOct 12, 2018
  5. Thomas GummererOct 12, 2018
  6. Jonathan NiederDec 27, 2018
  7. Junio C HamanoJan 3, 2019
  8. Jonathan NiederJan 3, 2019
  9. Thomas GummererJan 6, 2019
  10. Junio C HamanoJan 7, 2019
  11. Jonathan NiederJan 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.