From: Jeff King <peff@peff.net>
Date: Fri, 12 Oct 2018 19:11:35 GMT
Subject: Re: [PATCH] config.mak.dev: add -Wformat
Message-ID: <20181012191134.GE4917@sigill.intra.peff.net>
In-Reply-To: <20181012185450.GB52080@aiede.svl.corp.google.com>

On Fri, Oct 12, 2018 at 11:54:50AM -0700, Jonathan Nieder wrote:

> > I'm not opposed to making config.mak.dev a bit more redundant to handle
> > this case, but we'd probably want to include all of -Wall, since it
> > contains many other warnings we'd want to make sure are enabled.
> 
> Do you mean putting -Wall instead of -Wformat?

Yes.

> Should we add -Wextra too?  From a quick test, it seems to build okay.

We already do (though we have to then manually disable a few warnings
that we're not ready for -- see config.mak.dev).

-Peff