[PATCH] config.mak.dev: add -Wformat
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Oct 12, 2018, 18:40 UTC
- Message-ID
- <20181012184037.15076-1-t.gummerer@gmail.com>
801fa63a90 ("config.mak.dev: add -Wformat-security", 2018-09-08) added the -Wformat-security to the flags set in config.mak.dev. In the gcc man page this is documented as:
If -Wformat is specified, also warn about uses of format
functions that represent possible security problems. [...]That commit did however not add the -Wformat flag, and -Wformat is not specified anywhere else by default, so the added -Wformat-security had no effect. Newer versions of gcc (gcc 8.2.1 in this particular case) warn about this and thus compilation fails with this option set.
Fix that, and make -Wformat-security actually useful by adding the -Wformat flag as well. git compiles cleanly with both these flags applied.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> ---
Sorry for not catching this before the patch made it to next.
config.mak.dev | 1 + 1 file changed, 1 insertion(+)
diff --git a/config.mak.dev b/config.mak.dev index 92d268137f..bf6f943452 100644 --- a/config.mak.dev +++ b/config.mak.dev @@ -7,6 +7,7 @@ CFLAGS += -pedantic CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0 endif CFLAGS += -Wdeclaration-after-statement +CFLAGS += -Wformat CFLAGS += -Wformat-security CFLAGS += -Wno-format-zero-length CFLAGS += -Wold-style-definition
-- 2.19.1.937.g12227c8702.dirty