Re: [PATCH v3] coccicheck: process every source file at once

From: Jeff King <peff@peff.net>
Date: Oct 9, 2018, 03:15 UTC
Message-ID: <20181009031542.GD6250@sigill.intra.peff.net>
In-Reply-To: <20181005195413.GX23446@localhost>

On Fri, Oct 05, 2018 at 09:54:13PM +0200, SZEDER Gábor wrote:

Show 11 quoted lines

> Runtimes tend to fluctuate quite a bit more on Travis CI compared to
> my machine, but not this much, and it seems to be consistent so far.
> 
> After scripting/querying the Travis CI API a bit, I found that from
> the last 100 static analysis build jobs 78 did actully run 'make
> coccicheck' [1], avaraging 470s for the whole build job, with only 4
> build job exceeding the 10min mark.
> 
> I had maybe 6-8 build jobs running this patch over the last 2-3 days,
> I think all of them were over 15min.  (I restarted some of them, so I
> don't have separate logs for all of them, hence the uncertainty.)

So that's really weird and counter-intuitive, since we should be doing strictly less work. I know that spatch tries to parallelize itself, though from my tests, 1.0.4 does not. I wonder if the version in Travis differs in that respect and starts too many threads, and the extra time is going to contention and context switches.

Have you tried passing "-j1" to spatch? My 1.0.4 does not even recognize it.

That seems like a pretty unlikely explanation to me, but I am having trouble coming up with another one.

I guess the other plausible thing is that the extra memory is forcing us into some slower path. E.g., a hypervisor may even be swapping, unbeknownst to the child OS, and it gets accounted in the child OS as "boy, that memory load was really slow", which becomes used CPU.

That actually sounds more credible to me.

-Peff