Re: [PATCH v3] coccicheck: process every source file at once

From: Jeff King <peff@peff.net>
Date: Oct 5, 2018, 16:25 UTC
Message-ID: <20181005162517.GB11254@sigill.intra.peff.net>
In-Reply-To: <20181005124048.GT23446@localhost>

On Fri, Oct 05, 2018 at 02:40:48PM +0200, SZEDER Gábor wrote:

Show 14 quoted lines

> On Thu, Oct 04, 2018 at 07:17:47PM -0700, Jacob Keller wrote:
> > Junio, do you want me to update the commit message on my side with the
> > memory concerns? Or could you update it to mention memory as a noted
> > trade off.
> 
> We have been running 'make -j2 coccicheck' in the static analysis
> build job on Travis CI, which worked just fine so far.  The Travis CI
> build environments have 3GB of memory available [1], but, as shown in
> [2], with this patch the memory consumption jumps up to about
> 1.3-1.8GB for each of those jobs.  So with two parallel jobs we will
> very likely bump into this limit.
> 
> So this patch should definitely change that build script to run only a
> single job.

It should still be a net win, since the total CPU seems to drop by a factor of 3-4.

Are we OK with saying 1.3-1.8GB is necessary to run coccicheck? That doesn't feel like an exorbitant request for a developer-only tool these days, but I have noticed some people on the list tend to have lousier machines than I do. ;)

-Peff