git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH v3] coccicheck: process every source file at once

From
Keller, Jacob E <jacob.e.keller@intel.com>
Date
Oct 5, 2018, 16:53 UTC
Message-ID
<02874ECE860811409154E81DA85FBB5884CCBED2@ORSMSX115.amr.corp.intel.com>
In-Reply-To
<20181005162517.GB11254@sigill.intra.peff.net>
Show 34 quoted lines
> -----Original Message-----
> From: Jeff King [mailto:peff@peff.net]
> Sent: Friday, October 05, 2018 9:25 AM
> To: SZEDER Gábor <szeder.dev@gmail.com>
> Cc: Jacob Keller <jacob.keller@gmail.com>; Keller, Jacob E
> <jacob.e.keller@intel.com>; Git mailing list <git@vger.kernel.org>
> Subject: Re: [PATCH v3] coccicheck: process every source file at once
> 
> On Fri, Oct 05, 2018 at 02:40:48PM +0200, SZEDER Gábor wrote:
> 
> > On Thu, Oct 04, 2018 at 07:17:47PM -0700, Jacob Keller wrote:
> > > Junio, do you want me to update the commit message on my side with the
> > > memory concerns? Or could you update it to mention memory as a noted
> > > trade off.
> >
> > We have been running 'make -j2 coccicheck' in the static analysis
> > build job on Travis CI, which worked just fine so far.  The Travis CI
> > build environments have 3GB of memory available [1], but, as shown in
> > [2], with this patch the memory consumption jumps up to about
> > 1.3-1.8GB for each of those jobs.  So with two parallel jobs we will
> > very likely bump into this limit.
> >
> > So this patch should definitely change that build script to run only a
> > single job.
> 
> It should still be a net win, since the total CPU seems to drop by a
> factor of 3-4.
> 
> Are we OK with saying 1.3-1.8GB is necessary to run coccicheck? That
> doesn't feel like an exorbitant request for a developer-only tool these
> days, but I have noticed some people on the list tend to have lousier
> machines than I do. ;)
> 
> -Peff
It's probably not worth trying to make this more complicated and scale up how many files we do at once based on the amount of available memory on the system...

Thanks, Jake

Previous: Jeff KingNext: Jeff King
Message 6 of 20 in “coccicheck: process every source file at once”
  1. coccicheck: process every source file at onceJacob Keller, Oct 2, 2018
  2. Jacob KellerOct 2, 2018
  3. Jacob KellerOct 5, 2018
  4. SZEDER GáborOct 5, 2018
  5. Jeff KingOct 5, 2018
  6. Keller, Jacob EOct 5, 2018
  7. Jeff KingOct 5, 2018
  8. SZEDER GáborOct 5, 2018
  9. Jeff KingOct 5, 2018
  10. Jacob KellerOct 5, 2018
  11. René ScharfeOct 6, 2018
  12. Jeff KingOct 9, 2018
  13. SZEDER GáborOct 5, 2018
  14. Jeff KingOct 5, 2018
  15. SZEDER GáborOct 5, 2018
  16. Jeff KingOct 9, 2018
  17. SZEDER GáborOct 10, 2018
  18. Jeff KingOct 10, 2018
  19. Beat BolliOct 7, 2018
  20. Beat BolliOct 7, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.