Re: [PATCH 0/9] Add missing includes and forward declares

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 15, 2018, 04:57 UTC
Message-ID: <20180815045759.GB32543@aiede.svl.corp.google.com>
In-Reply-To: <20180815013825.GA12178@sigill.intra.peff.net>

Jeff King wrote:

Show 11 quoted lines

> Subject: [PATCH] test-tool.h: include git-compat-util.h
>
> The test-tool programs include "test-tool.h" as their first
> include, which breaks our CodingGuideline of "the first
> include must be git-compat-util.h or an equivalent". This
> isn't actually a problem, as test-tool.h doesn't define
> anything tricky, but we should probably follow our own rule.
>
> Rather than change them all, let's instead make test-tool.h
> one of those equivalents, just like we do for builtin.h
> (which many of the actual git builtins include first).

I wonder if it would not be simpler to change them all. It would be one less special case.

That said,

> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  t/helper/test-tool.h | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.