[PATCHv2 0/6] Add missing includes and forward declares
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 11, 2018, 20:50 UTC
- Message-ID
- <20180811205024.11291-1-newren@gmail.com>
- In-Reply-To
- <20180811043218.31456-1-newren@gmail.com>
This series fixes compilation errors when using a simple test.c file that includes git-compat-util.h and then exactly one other header (and repeating this for different headers of git).
Changes since v1:
- Followed Peff's suggestion to make my simple test .c file first
#include git-compat-util.h; removes the need for inclusions of this
header or stdlib.h or stdio.h throughout my series. (Patches 6-8 of
v1 no longer necessary at all.)
- Removed the explanatory comments about why various #include's were
needed from v1.Note: the final patch has minor conflicts with topics in flight in next and pu; it can just be dropped and I can resubmit it later if that is easier.
Elijah Newren (6): Add missing includes and forward declares alloc: make allocate_alloc_state and clear_alloc_state more consistent Move definition of enum branch_track from cache.h to branch.h urlmatch.h: fix include guard compat/precompose_utf8.h: use more common include guard style Add missing includes and forward declares
alloc.c | 2 +- alloc.h | 4 +++- apply.h | 3 +++ archive.h | 3 +++ attr.h | 1 + bisect.h | 2 ++ branch.h | 13 +++++++++++++ bulk-checkin.h | 2 ++ cache.h | 10 ---------- column.h | 1 + commit-graph.h | 1 + compat/precompose_utf8.h | 3 ++- config.c | 1 + config.h | 5 +++++ connected.h | 1 + convert.h | 2 ++ csum-file.h | 2 ++ diffcore.h | 4 ++++ dir-iterator.h | 2 ++ environment.c | 1 + fsck.h | 1 + fsmonitor.h | 7 +++++++ gpg-interface.h | 2 ++ khash.h | 3 +++ list-objects-filter.h | 4 ++++ list-objects.h | 4 ++++ ll-merge.h | 2 ++ mailinfo.h | 2 ++ mailmap.h | 2 ++ merge-recursive.h | 4 +++- notes-merge.h | 4 ++++ notes-utils.h | 3 +++ notes.h | 3 +++ object-store.h | 1 + object.h | 2 ++ oidmap.h | 1 + pack-bitmap.h | 3 +++ pack-objects.h | 1 + patch-ids.h | 6 ++++++ path.h | 1 + pathspec.h | 5 +++++ pretty.h | 4 ++++ reachable.h | 2 ++ reflog-walk.h | 1 + refs.h | 2 ++ remote.h | 1 + repository.h | 2 ++ resolve-undo.h | 2 ++ revision.h | 1 + send-pack.h | 4 ++++ sequencer.h | 5 +++++ shortlog.h | 2 ++ submodule.h | 10 ++++++++-- tempfile.h | 1 + trailer.h | 2 ++ tree-walk.h | 2 ++ unpack-trees.h | 5 ++++- url.h | 2 ++ urlmatch.h | 2 ++ utf8.h | 2 ++ worktree.h | 1 + 61 files changed, 160 insertions(+), 17 deletions(-)
-- 2.18.0.549.gd4454f3f9b