git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 3/6] Move definition of enum branch_track from cache.h to branch.h

From
Elijah Newren <newren@gmail.com>
Date
Aug 11, 2018, 20:50 UTC
Message-ID
<20180811205024.11291-4-newren@gmail.com>
In-Reply-To
<20180811205024.11291-1-newren@gmail.com>

'branch_track' feels more closely related to branching, and it is needed later in branch.h; rather than #include'ing cache.h in branch.h for this small enum, just move the enum and the external declaration for git_branch_track to branch.h.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 branch.h      | 11 +++++++++++
 cache.h       | 10 ----------
 config.c      |  1 +
 environment.c |  1 +
 4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/branch.h b/branch.h
index 7d9b330eba..5cace4581f 100644
--- a/branch.h
+++ b/branch.h
@@ -3,6 +3,17 @@
 
 struct strbuf;
 
+enum branch_track {
+	BRANCH_TRACK_UNSPECIFIED = -1,
+	BRANCH_TRACK_NEVER = 0,
+	BRANCH_TRACK_REMOTE,
+	BRANCH_TRACK_ALWAYS,
+	BRANCH_TRACK_EXPLICIT,
+	BRANCH_TRACK_OVERRIDE
+};
+
+extern enum branch_track git_branch_track;
+
 /* Functions for acting on the information about branches. */
 
 /*
diff --git a/cache.h b/cache.h
index 8dc7134f00..a1c0c594fb 100644
--- a/cache.h
+++ b/cache.h
@@ -919,15 +919,6 @@ enum log_refs_config {
 };
 extern enum log_refs_config log_all_ref_updates;
 
-enum branch_track {
-	BRANCH_TRACK_UNSPECIFIED = -1,
-	BRANCH_TRACK_NEVER = 0,
-	BRANCH_TRACK_REMOTE,
-	BRANCH_TRACK_ALWAYS,
-	BRANCH_TRACK_EXPLICIT,
-	BRANCH_TRACK_OVERRIDE
-};
-
 enum rebase_setup_type {
 	AUTOREBASE_NEVER = 0,
 	AUTOREBASE_LOCAL,
@@ -944,7 +935,6 @@ enum push_default_type {
 	PUSH_DEFAULT_UNSPECIFIED
 };
 
-extern enum branch_track git_branch_track;
 extern enum rebase_setup_type autorebase;
 extern enum push_default_type push_default;
 
diff --git a/config.c b/config.c
index 66645047eb..b60d7c0308 100644
--- a/config.c
+++ b/config.c
@@ -5,6 +5,7 @@
  * Copyright (C) Johannes Schindelin, 2005
  *
  */
+#include "branch.h"
 #include "cache.h"
 #include "config.h"
 #include "repository.h"
diff --git a/environment.c b/environment.c
index 6cf0079389..920362900c 100644
--- a/environment.c
+++ b/environment.c
@@ -7,6 +7,7 @@
  * even if you might want to know where the git directory etc
  * are.
  */
+#include "branch.h"
 #include "cache.h"
 #include "repository.h"
 #include "config.h"
-- 
2.18.0.549.gd4454f3f9b
Previous: Elijah NewrenNext: Ramsay Jones
Message 29 of 49 in “Add missing includes and forward declares”
  1. 0/9 Add missing includes and forward declaresElijah Newren, Aug 11, 2018
  2. 5/9 compat/precompose_utf8.h: use more common include guard styleElijah Newren, Aug 11, 2018
  3. 3/9 Move definition of enum branch_track from cache.h to branch.hElijah Newren, Aug 11, 2018
  4. 9/9 Add missing includes and forward declaresElijah Newren, Aug 11, 2018
  5. 1/9 Add missing includes and forward declaresElijah Newren, Aug 11, 2018
  6. Jeff KingAug 11, 2018
  7. 4/9 urlmatch.h: fix include guardElijah Newren, Aug 11, 2018
  8. 2/9 alloc: make allocate_alloc_state and clear_alloc_state more consistentElijah Newren, Aug 11, 2018
  9. 6/9 ewah/ewok.h: add missing includeElijah Newren, Aug 11, 2018
  10. 8/9 xdiff/xdiff.h: add missing includeElijah Newren, Aug 11, 2018
  11. 7/9 sha1dc/sha1.h: add missing includeElijah Newren, Aug 11, 2018
  12. Ævar Arnfjörð BjarmasonAug 11, 2018
  13. Elijah NewrenAug 11, 2018
  14. Jeff KingAug 11, 2018
  15. Junio C HamanoAug 13, 2018
  16. Elijah NewrenAug 14, 2018
  17. Junio C HamanoAug 15, 2018
  18. Elijah NewrenAug 15, 2018
  19. Junio C HamanoAug 15, 2018
  20. Elijah NewrenAug 15, 2018
  21. Junio C HamanoAug 15, 2018
  22. Jeff KingAug 15, 2018
  23. Jonathan NiederAug 15, 2018
  24. Jonathan NiederAug 15, 2018
  25. 0/6 Add missing includes and forward declaresElijah Newren, Aug 11, 2018
  26. 6/6 Add missing includes and forward declaresElijah Newren, Aug 11, 2018
  27. 2/6 alloc: make allocate_alloc_state and clear_alloc_state more consistentElijah Newren, Aug 11, 2018
  28. 4/6 urlmatch.h: fix include guardElijah Newren, Aug 11, 2018
  29. 3/6 Move definition of enum branch_track from cache.h to branch.hElijah Newren, Aug 11, 2018
  30. Ramsay JonesAug 11, 2018
  31. 1/6 Add missing includes and forward declaresElijah Newren, Aug 11, 2018
  32. 5/6 compat/precompose_utf8.h: use more common include guard styleElijah Newren, Aug 11, 2018
  33. 0/6 Add missing includes and forward declaresElijah Newren, Aug 13, 2018
  34. 4/6 urlmatch.h: fix include guardElijah Newren, Aug 13, 2018
  35. Jonathan NiederAug 15, 2018
  36. 3/6 Move definition of enum branch_track from cache.h to branch.hElijah Newren, Aug 13, 2018
  37. Jonathan NiederAug 15, 2018
  38. 5/6 compat/precompose_utf8.h: use more common include guard styleElijah Newren, Aug 13, 2018
  39. Jonathan NiederAug 15, 2018
  40. 2/6 alloc: make allocate_alloc_state and clear_alloc_state more consistentElijah Newren, Aug 13, 2018
  41. Jonathan NiederAug 15, 2018
  42. 6/6 Add missing includes and forward declaresElijah Newren, Aug 13, 2018
  43. Jonathan NiederAug 15, 2018
  44. 1/6 Add missing includes and forward declaresElijah Newren, Aug 13, 2018
  45. Jonathan NiederAug 15, 2018
  46. Elijah NewrenAug 15, 2018
  47. Jonathan NiederAug 15, 2018
  48. Elijah NewrenAug 15, 2018
  49. Elijah NewrenAug 15, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.