git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] builtin rebase: actions require a rebase in progress

From
Pratik Karki <predatoramigo@gmail.com>
Date
Aug 8, 2018, 15:06 UTC
Message-ID
<20180808150622.9614-7-predatoramigo@gmail.com>
In-Reply-To
<20180808150622.9614-1-predatoramigo@gmail.com>

This commit prevents actions (such as --continue, --skip) from running when there is no rebase in progress.

Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
---
 builtin/rebase.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index e3dd2f511e..1344e071f3 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -577,6 +577,9 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 		usage_with_options(builtin_rebase_usage,
 				   builtin_rebase_options);
 
+	if (action != NO_ACTION && !in_progress)
+		die(_("No rebase in progress?"));
+
 	if (action == ACTION_EDIT_TODO && !is_interactive(&options))
 		die(_("The --edit-todo action can only be used during "
 		      "interactive rebase."));
-- 
2.18.0
Previous: Pratik KarkiNext: Pratik Karki
Message 7 of 8 in “builtin rebase actions”
  1. Pratik KarkiAug 8, 2018
  2. 1/7 builtin rebase: support --continuePratik Karki, Aug 8, 2018
  3. 2/7 builtin rebase: support --skipPratik Karki, Aug 8, 2018
  4. 3/7 builtin rebase: support --abortPratik Karki, Aug 8, 2018
  5. 4/7 builtin rebase: support --quitPratik Karki, Aug 8, 2018
  6. 5/7 builtin rebase: support --edit-todo and --show-current-patchPratik Karki, Aug 8, 2018
  7. 6/7 builtin rebase: actions require a rebase in progressPratik Karki, Aug 8, 2018
  8. 7/7 builtin rebase: stop if `git am` is in progressPratik Karki, Aug 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.