git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/7] builtin rebase: support --quit

From
Pratik Karki <predatoramigo@gmail.com>
Date
Aug 8, 2018, 15:06 UTC
Message-ID
<20180808150622.9614-5-predatoramigo@gmail.com>
In-Reply-To
<20180808150622.9614-1-predatoramigo@gmail.com>

With this patch, the builtin rebase handles the `--quit` action which can be used to abort a rebase without rolling back any changes performed during the rebase (this is useful when a user forgot that they were in the middle of a rebase and continued working normally).

Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
---
 builtin/rebase.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 8e94f6cc85..0d805480a1 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -471,6 +471,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 		ACTION_CONTINUE,
 		ACTION_SKIP,
 		ACTION_ABORT,
+		ACTION_QUIT,
 	} action = NO_ACTION;
 	struct option builtin_rebase_options[] = {
 		OPT_STRING(0, "onto", &options.onto_name,
@@ -500,6 +501,8 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 		OPT_CMDMODE(0, "abort", &action,
 			    N_("abort and check out the original branch"),
 			    ACTION_ABORT),
+		OPT_CMDMODE(0, "quit", &action,
+			    N_("abort but keep HEAD where it is"), ACTION_QUIT),
 		OPT_END(),
 	};
 
@@ -628,6 +631,14 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 		ret = finish_rebase(&options);
 		goto cleanup;
 	}
+	case ACTION_QUIT: {
+		strbuf_reset(&buf);
+		strbuf_addstr(&buf, options.state_dir);
+		ret = !!remove_dir_recursively(&buf, 0);
+		if (ret)
+			die(_("could not remove '%s'"), options.state_dir);
+		goto cleanup;
+	}
 	default:
 		die("TODO");
 	}
-- 
2.18.0
Previous: Pratik KarkiNext: Pratik Karki
Message 5 of 8 in “builtin rebase actions”
  1. Pratik KarkiAug 8, 2018
  2. 1/7 builtin rebase: support --continuePratik Karki, Aug 8, 2018
  3. 2/7 builtin rebase: support --skipPratik Karki, Aug 8, 2018
  4. 3/7 builtin rebase: support --abortPratik Karki, Aug 8, 2018
  5. 4/7 builtin rebase: support --quitPratik Karki, Aug 8, 2018
  6. 5/7 builtin rebase: support --edit-todo and --show-current-patchPratik Karki, Aug 8, 2018
  7. 6/7 builtin rebase: actions require a rebase in progressPratik Karki, Aug 8, 2018
  8. 7/7 builtin rebase: stop if `git am` is in progressPratik Karki, Aug 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.