git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/7] builtin rebase: support --skip

From
Pratik Karki <predatoramigo@gmail.com>
Date
Aug 8, 2018, 15:06 UTC
Message-ID
<20180808150622.9614-3-predatoramigo@gmail.com>
In-Reply-To
<20180808150622.9614-1-predatoramigo@gmail.com>

This commit adds the option `--skip` which is used to restart rebase after skipping the current patch.

Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
---
 builtin/rebase.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 10da4c978b..7a903838b1 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -21,6 +21,7 @@
 #include "diff.h"
 #include "wt-status.h"
 #include "revision.h"
+#include "rerere.h"
 
 static char const * const builtin_rebase_usage[] = {
 	N_("git rebase [-i] [options] [--exec <cmd>] [--onto <newbase>] "
@@ -468,6 +469,7 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 	enum {
 		NO_ACTION,
 		ACTION_CONTINUE,
+		ACTION_SKIP,
 	} action = NO_ACTION;
 	struct option builtin_rebase_options[] = {
 		OPT_STRING(0, "onto", &options.onto_name,
@@ -492,6 +494,8 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 			REBASE_FORCE),
 		OPT_CMDMODE(0, "continue", &action, N_("continue"),
 			    ACTION_CONTINUE),
+		OPT_CMDMODE(0, "skip", &action,
+			    N_("skip current patch and continue"), ACTION_SKIP),
 		OPT_END(),
 	};
 
@@ -590,6 +594,20 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 			exit(1);
 		goto run_rebase;
 	}
+	case ACTION_SKIP: {
+		struct string_list merge_rr = STRING_LIST_INIT_DUP;
+
+		options.action = "skip";
+
+		rerere_clear(&merge_rr);
+		string_list_clear(&merge_rr, 1);
+
+		if (reset_head(NULL, "reset", NULL, 0) < 0)
+			die(_("could not discard worktree changes"));
+		if (read_basic_state(&options))
+			exit(1);
+		goto run_rebase;
+	}
 	default:
 		die("TODO");
 	}
-- 
2.18.0
Previous: Pratik KarkiNext: Pratik Karki
Message 3 of 8 in “builtin rebase actions”
  1. Pratik KarkiAug 8, 2018
  2. 1/7 builtin rebase: support --continuePratik Karki, Aug 8, 2018
  3. 2/7 builtin rebase: support --skipPratik Karki, Aug 8, 2018
  4. 3/7 builtin rebase: support --abortPratik Karki, Aug 8, 2018
  5. 4/7 builtin rebase: support --quitPratik Karki, Aug 8, 2018
  6. 5/7 builtin rebase: support --edit-todo and --show-current-patchPratik Karki, Aug 8, 2018
  7. 6/7 builtin rebase: actions require a rebase in progressPratik Karki, Aug 8, 2018
  8. 7/7 builtin rebase: stop if `git am` is in progressPratik Karki, Aug 8, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.