[PATCH v2 12/11] completion: complete general config vars in two steps
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- May 27, 2018, 18:28 UTC
- Message-ID
- <20180527182800.25109-1-pclouds@gmail.com>
- In-Reply-To
- <20180526135531.4516-12-pclouds@gmail.com>
There are 581 config variables as of now when you do "git config <tab>" which can fill up a few screens and is not very helpful when you have to look through columns of text to find what you want.
This patch instead shows you only first level when you do
git config <tab>
There are 78 items, which use up 8 rows in my screen. Compared to screens of text, it's pretty good. Once you have chosen you first level, e.g. color:
git config color.<tab>
will show you all color.*
This is not a new idea. branch.* and remote.* completion already does this for second and third levels. For those variables, you'll need to <tab> three times to get full variable name.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- I mentioned about this a while back in the --no-... completion RFC. It turns out not that hard to do, especially when branch.* and remote.* already kinda set a precedence.
contrib/completion/git-completion.bash | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 2cbd14b346..ab026776df 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2314,9 +2314,14 @@ _git_config () __gitcomp "insteadOf pushInsteadOf" "$pfx" "$cur_" return ;; + *.*) + __git_compute_config_vars + __gitcomp "$__git_config_vars" + ;; + *) + __git_compute_config_vars + __gitcomp "$(echo "$__git_config_vars" | sed 's/\.[^ ]*/./g')" esac - __git_compute_config_vars - __gitcomp "$__git_config_vars" } _git_remote ()
-- 2.17.0.705.g3525833791