Re: [PATCH 1/5] http: use strbufs instead of fixed buffers

From: Jeff King <peff@peff.net>
Date: May 21, 2018, 19:41 UTC
Message-ID: <20180521194120.GA9742@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kYZ9HSCC95qCZ4Zix1oEFLscsU1HZe64s--6KuWEz2ojg@mail.gmail.com>

On Mon, May 21, 2018 at 11:11:51AM -0700, Stefan Beller wrote:

Show 9 quoted lines

> Hi Jeff,
> 
> On Fri, May 18, 2018 at 6:56 PM, Jeff King <peff@peff.net> wrote:
> 
> > @@ -2421,4 +2426,5 @@ void release_http_object_request(struct http_object_request *freq)
> ..
> > +       strbuf_release(&freq->tmpfile);
> 
> Do we need an equivalent in release_http_pack_request as well?

Yes, but isn't there one?

From the original patch:

--- a/http.c
+++ b/http.c
@@ -2082,6 +2082,7 @@ void release_http_pack_request(struct http_pack_request *preq)
                preq->packfile = NULL;
        }
        preq->slot = NULL;
+       strbuf_release(&preq->tmpfile);
        free(preq->url);
        free(preq);
 }

Or am I missing something?

-Peff